Skip to content

Unsent manual request keeps a blocked payment reservation #1106

Closed

Description

@ben-kaufman

The manual incoming Bitcoin payment path reserves an allowance-ledger attempt before on-chain admission. A retained unrelated payment can then reject the new request before its broadcast callback, but SendConfirmationView handles that unresolved error by recording the new reservation as UNKNOWN. Its journal has no transaction ID/payment hash, so retry can remain blocked.

The path is present on master 07610b3: OnchainSendAttemptService rejects at admission, while SendConfirmationView treats every unresolved attempt error as the current payment's uncertain outcome. This matches the independently reproduced Android #1656 review finding. iOS native reproduction has not been run by the author.

Carry known blocker ownership from admission, release only the definitely unsent different request's reservation/preparation, and keep the original recovery route. Preserve same-request, unknown/unreadable state, fresh authorization and duplicate-payment protection.

Activity

  1. added this to the 3.2.0 milestone on Oct 23, 2026
  2. ovitrif commented on Oct 23, 2026

    @ovitrif
    Collaborator

    Triage: 3.2.0, with its Android twin synonymdev/bitkit-android#1675. It's a retry edge case in inherited code with no device reproduction yet, and 3.1.0 ships today.

  3. modified the milestones: 3.2.0, 3.1.0 on Oct 23, 2026
  4. ovitrif commented on Oct 23, 2026

    @ovitrif
    Collaborator

    Moved to 3.1.0: fixes for features shipped in 3.0.x go in 3.1.0, now due 28 Oct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions