Skip to content

fix: slide the usdt wallet in like the other wallets - #1589

Closed
ovitrif wants to merge 1 commit into
masterfrom
fix/usdt-wallet-slide
Closed

ovitrif wants to merge 1 commit into
masterfrom
fix/usdt-wallet-slide

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #1519

Description

  • Fixes the USDT wallet fading over Home instead of sliding in, because its screen had no background: the slide showed Home through it, so both screens' content overlapped for the whole transition. It now paints the same black background as the Savings, Spending and hardware wallet screens.
  • Blocks taps from passing through the USDT wallet to Home, as the other wallet screens do.

Out of Scope

Design

N/A — no design change. The screen keeps its Savings, Spending, Hardware, USDT Balances › Wallet USDT (funds & activity) frame; only its background and transition are fixed.

Preview

Before: USDT fades in over Home

before-2x.mp4

After: USDT slides in and out like Spending

after-2x.mp4

Both recorded on an Android 16 emulator with animations at 3x duration, played at 2x. Each opens USDT, goes back, then opens Spending for comparison.

QA Notes

Journeys

  • updated usdt-wallet-navigation.xml — USDT opens and closes with the same slide as Savings and Spending, with no Home content showing through

Manual Tests

N/A

Automated Checks

N/A

@ovitrif ovitrif added this to the 3.1.0 milestone Oct 19, 2026
@ovitrif ovitrif self-assigned this Oct 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T17:48:51.396055Z 586f632 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif

ovitrif commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as a duplicate of #1565 (@ben-kaufman), which already gives the USDT wallet its opaque background and says Fixes #1519. The one extra here, .blockPointerInputPassthrough() so taps don't reach Home through the wallet like on the other wallet screens, is suggested on #1565.

@ovitrif ovitrif closed this Oct 19, 2026
@ovitrif
ovitrif requested a review from a team October 19, 2026 17:48
@ovitrif
ovitrif deleted the fix/usdt-wallet-slide branch October 19, 2026 17:48
@ovitrif
ovitrif requested review from coreyphillips and pwltr and removed request for a team October 19, 2026 17:48
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The USDT wallet now paints a black background and blocks taps from reaching Home.

  • The USDT wallet slides in and out without showing Home through it.

Reviews (1) · Last reviewed commit: "fix: slide the usdt wallet in like the o..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Regtest APK

Built from 586f632 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: usdt wallet fades in and out instead of sliding like the other wallets

1 participant