Repository navigation
chore: translate pubky profile loading strings - #1546
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Low impact] The PR appears safe to merge. SummaryAdds
ovitrif explicitly deferred native-speaker review until before release. Reviews (1) · Last reviewed commit: "chore: translate pubky profile loading s..." · Reviewed by Greptile |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdfc971d9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Adds translations of pubky_auth__loading_identity and pubky_auth__loading_identity_desc to the 15 shipped locales. Reviewed fdfc971, light tier.
What I checked
- Both English keys exist on the base (
values/strings.xml), and none of the 15 locale files had them before; the PR adds exactly two lines to each, in English key order next topubky_auth__identity_unavailable_desc. - Apostrophes are escaped where they appear (
ca,fr),values-ptandvalues-pt-rBRfollow European and Brazilian conventions, and title casing matches each locale's neighbouringpubky_auth__*strings (it,pt-rBR,ru). - CI: build, lint, detekt green.
Merge confidence: 5/5, CI green and the change is copy only.
jvsena42
left a comment
There was a problem hiding this comment.
Code scan at fdfc971: no findings.
Checked:
- The base keys are on master: #1514 is merged, and
values/strings.xml:751-752has both. The 15 locales that carry the siblingpubky_auth__identity_unavailableeach get both keys, with exact names. They sit betweenidentity_unavailable_descandno_identity, as in English. - Apostrophes are escaped (ca
S\'està,d\'inici; frs\'ouvrira). No placeholders,&or quotes. - Wording follows the neighbouring
pubky_auth__*strings in each file: the same profile term, the same formal or informal register, and Title Case where the neighbours use it. Arabic reuses "ملف Pubky الشخصي" and "تسجيل الدخول", and the file uses no bidi marks. - Rendering:
ToastView.kt:191-199. The title (BodyMSB) and description (Caption) have nomaxLines, so long locales wrap rather than truncate. Locales at least 30% over English: ca (title and description ×1.50), pt (description ×1.48), es / es-rES / es-419 (description ×1.31), pt-rBR (description ×1.30).
Device gate (partial): fdfc971 — not run yet. The wait toast sets autoHide = false (AppViewModel.kt:3162-3169), so the close X is overlaid 16–32 dp from the trailing edge, while the title row has no end padding (ToastView.kt:181-199). Pending: the toast in ca, it, pl, fr, pt, es, de and ar on a ~360 dp screen, checking for text running under the X. The device result will follow.
|
Device gate: |
Refs: #1514
Description
pubky_auth__loading_identityandpubky_auth__loading_identity_desc, the Pubky profile loading screen shown when a sign-in request opens on cold start, in all 15 shipped locales.pubky_auth__*strings; "Pubky" stays untranslated.values-ptgets European Portuguese andvalues-pt-rBRgets Brazilian Portuguese, as in the 3.0.0 pass.Out of Scope
Design
N/A — no UI changes.
Preview
N/A — translation-only change.
QA Notes
Journeys
N/A — not drivable; the loading screen only shows while the profile loads on a cold start.
Manual Tests
N/A
Automated Checks
processDevDebugResources(all locales compile)