Skip to content

chore: translate pubky profile loading strings - #1546

Merged
ovitrif merged 1 commit into
masterfrom
chore/translate-pubky-loading-identity
Oct 16, 2026
Merged

ovitrif merged 1 commit into
masterfrom
chore/translate-pubky-loading-identity

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Refs: #1514

Description

  • Adds AI-assisted translations for pubky_auth__loading_identity and pubky_auth__loading_identity_desc, the Pubky profile loading screen shown when a sign-in request opens on cold start, in all 15 shipped locales.
  • Wording, register and title casing follow each locale's existing pubky_auth__* strings; "Pubky" stays untranslated.
  • New keys are inserted in English key order; existing translations and English are unchanged.
  • values-pt gets European Portuguese and values-pt-rBR gets Brazilian Portuguese, as in the 3.0.0 pass.
  • iOS has no matching keys, so nothing was copied from iOS.

Out of Scope

  • Native review: the new strings need a native speaker before release, like the rest of the 3.0.0 pass.
  • Transifex: not used; these strings exist only in the repo.

Design

N/A — no UI changes.

Preview

N/A — translation-only change.

QA Notes

Journeys

N/A — not drivable; the loading screen only shows while the profile loads on a cold start.

Manual Tests

N/A

Automated Checks

  • ran processDevDebugResources (all locales compile)

@ovitrif ovitrif added this to the 3.0.0 milestone Oct 16, 2026
@ovitrif ovitrif self-assigned this Oct 16, 2026
@ovitrif
ovitrif requested review from a team, ben-kaufman and coreyphillips and removed request for a team October 16, 2026 17:43
@ovitrif
ovitrif enabled auto-merge October 16, 2026 17:43
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T17:46:17.469860Z fdfc971 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Adds pubky_auth__loading_identity and pubky_auth__loading_identity_desc translations across all 15 shipped locales.

  • The Pubky loading toast now has translated text in 15 locales.

ovitrif explicitly deferred native-speaker review until before release.

Reviews (1) · Last reviewed commit: "chore: translate pubky profile loading s..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Regtest APK

Built from fdfc971 (run).

Download bitkit-dev-debug universal APK (expires in 30 days).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdfc971d9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/src/main/res/values-ar/strings.xml

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Adds translations of pubky_auth__loading_identity and pubky_auth__loading_identity_desc to the 15 shipped locales. Reviewed fdfc971, light tier.

What I checked
  • Both English keys exist on the base (values/strings.xml), and none of the 15 locale files had them before; the PR adds exactly two lines to each, in English key order next to pubky_auth__identity_unavailable_desc.
  • Apostrophes are escaped where they appear (ca, fr), values-pt and values-pt-rBR follow European and Brazilian conventions, and title casing matches each locale's neighbouring pubky_auth__* strings (it, pt-rBR, ru).
  • CI: build, lint, detekt green.

Merge confidence: 5/5, CI green and the change is copy only.

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code scan at fdfc971: no findings.

Checked:

  • The base keys are on master: #1514 is merged, and values/strings.xml:751-752 has both. The 15 locales that carry the sibling pubky_auth__identity_unavailable each get both keys, with exact names. They sit between identity_unavailable_desc and no_identity, as in English.
  • Apostrophes are escaped (ca S\'està, d\'inici; fr s\'ouvrira). No placeholders, & or quotes.
  • Wording follows the neighbouring pubky_auth__* strings in each file: the same profile term, the same formal or informal register, and Title Case where the neighbours use it. Arabic reuses "ملف Pubky الشخصي" and "تسجيل الدخول", and the file uses no bidi marks.
  • Rendering: ToastView.kt:191-199. The title (BodyMSB) and description (Caption) have no maxLines, so long locales wrap rather than truncate. Locales at least 30% over English: ca (title and description ×1.50), pt (description ×1.48), es / es-rES / es-419 (description ×1.31), pt-rBR (description ×1.30).

Device gate (partial): fdfc971 — not run yet. The wait toast sets autoHide = false (AppViewModel.kt:3162-3169), so the close X is overlaid 16–32 dp from the trailing edge, while the title row has no end padding (ToastView.kt:181-199). Pending: the toast in ca, it, pl, fr, pt, es, de and ar on a ~360 dp screen, checking for text running under the X. The device result will follow.

@ovitrif
ovitrif merged commit 0266f96 into master Oct 16, 2026
22 checks passed
@ovitrif
ovitrif deleted the chore/translate-pubky-loading-identity branch October 16, 2026 18:14
@jvsena42

Copy link
Copy Markdown
Member

Device gate: fdfc971 (recorded after merge). The sign-in loading toast at 360 dp shows no clipping in en, ca, it, pl, pt, es, de or ar, and Arabic mirrors correctly. In fr, the title runs under the toast's close X: ToastView reserves no space for the X when autoHide = false. Tracked in #1549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants