Repository navigation
chore: add translations for strings added after the 3.0.0 pass - #1509
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
 [Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryAdds 136 translations in each of 15 locales for USDT screens, payment requests, activity groups, subscriptions, and Pubky address sharing.
Acknowledgments from
Reviews (1) · Last reviewed commit: "chore: add translations for strings adde..." · Reviewed by Greptile |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52019d88d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Pushed bb151cb: adds the |
talosmachina
left a comment
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Adds the translations still missing after the 3.0.0 pass to all 15 Android locales, plus the changelog wording. Reviewed 52019d8, light tier: I read the strings with a script and did not judge them as a native speaker.
What I checked, and 3 candidates I ruled out
Checked mechanically on every added entry (2,040 across 15 files): each key exists in values/strings.xml; %n$d/%s and {name} placeholders match English per key; no unescaped apostrophe; no key defined twice in a file; every file parses as XML
CI: build, build-local, lint, detekt and Greptile green; local e2e still running at review time
Ruled out
- Placeholder mismatch in
wallet__payment_requests_pending_count: the script flags it only because the plural has more quantity items than English (ar 6, cs/pl/ru 4, the rest 3). Each item carries the same single%1$d. - Referenced strings left in English: 26 to 31 translatable keys per locale are still English-only (for example
usdt__deposit_create,profile__create_success). None of them is referenced fromapp/src/main/java, so the description's "every string the app references" holds. - English or existing translations touched: the only removed line is the changelog sentence that was rewritten.
Merge confidence: 5/5, CI green and the change is copy that a test would not apply to. The native-speaker pass the description lists under Out of Scope is still the real gate.
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
QA review
Scope: Reviewed the full PR diff against its merge base, at bb151cbc. This is a full review; no saved assessment baseline was available.
1 actionable finding — resolve or provide an evidence-backed rebuttal.
The 136 added strings in each of 15 locales keep the English format placeholders, {name} tokens, accent tags, and apostrophe escaping. The wrong-network warning, fee-direction errors, refund confirmation, and Paykit spend restriction match the English meaning in the locales read here. The German journey added after the Codex request uses receive and send labels, and UsdtNetworkPicker, that differ from these Android screens, so that journey cannot be completed as written.
Compared with bitkit-ios#953 at 926016fd: the journey file is the same. iOS wraps the receive network list in UsdtNetworkPicker. Android’s receive list is NetworkSelector without that tag. Shared copy matches aside from Android %1$s versus iOS {amount} on the deposit limits.
The resource build for this revision completed. This review did not run the journey or a device. It is not a native-speaker pass of all 15 locales; that check remains the one the PR description leaves open.
Device testing: not performed in this review.
Suggested additional test cases
- Android, dev build, fresh onboarded wallet with USDT and cross-network deposits configured, language Deutsch. On the Receive USDT tab, expect the title “Dollar empfangen” and the network control “Netzwerk: Arbitrum One”. Open the network list and expect the title “USDT-Netzwerk”, the German receive-network note, and the button “Einzahlungen anderer Netze” on that same page. Tap it and expect the title “Einzahlungen anderer Netze” and the empty state “Noch keine Einzahlungen.”
- On that wallet, open the USDT wallet and Send. Expect the title “USDT senden” and the network caption “Netzwerk”.
Findings
- [MEDIUM] Match the German USDT journey to the Android screens — inline at
journeys/usdt-german-labels.xml:16.
|
Pushed 502b2d1: |
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
QA review
Scope: Re-reviewed changes since bb151cbc, including the German USDT journey and the receive, network-list, deposits, and send paths it names, at 502b2d16. Inherited the previous QA review for the 136 added keys in all 15 locales, the high-risk copy, the changelog wording, and the de/ar/fr/es/pt/ru copies of those keys on bitkit-ios#953 at 926016fd.
No new actionable code findings.
The updated journey matches these Android screens: Receive shows “Dollar empfangen” and “Netzwerk: Arbitrum One”; the network list is titled “USDT-Netzwerk”, its note is the German receive-network note, and “Einzahlungen anderer Netze” is on that list; Send is titled “USDT senden” with the network caption “Netzwerk”. The same file on iOS at d41f428a matches that receive and send structure. iOS still wraps the receive list in UsdtNetworkPicker and Android’s list does not; the journey no longer asserts that tag. The journey mismatch from the previous review is resolved on this revision.
The dev build for this revision succeeded. This review parsed the journey XML and did not run the journey or a device. Local end-to-end jobs on this revision were still in progress. Native-speaker review of the payment and recovery copy remains the check the PR description leaves open.
Device testing: not performed in this review.
Ready for device testing.
|
Pushed 5e55fd8: the German USDT journey quotes the send network caption as rendered, "NETZWERK", the same fix @piotr-iohk raised on the iOS twin. |
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
QA review
Scope: Follow-up since 502b2d16, at 5e55fd86. Inherited the previous QA review for the 136 added keys in all 15 locales, the high-risk copy, the changelog wording, and the de/ar/fr/es/pt/ru copies of those keys on bitkit-ios#953 (those locale files remain unchanged through 4488114c). This pass checked the German USDT send caption in journeys/usdt-german-labels.xml and the send screen that renders it.
No new actionable code findings.
The send step now expects the network row caption "NETZWERK". Opening Send from the USDT wallet lands on the recipient page, titled "USDT senden" through SheetTopBar, and the network row caption is usdt__network ("Netzwerk") drawn by Caption13Up, which uppercases the string before display. German, root, and English uppercase of that word is NETZWERK. The other journey lines are unchanged from 502b2d1. The journey file matches bitkit-ios#953 at 4488114c, where SendSectionView draws the same German key with CaptionMText's uppercase text case. Android locale files and changelog.d/next/1492.added.md are unchanged since 502b2d1.
This review parsed the journey XML and checked the uppercase transform locally. It did not run the journey or a device. The dev build for this revision succeeded. Native-speaker review of the payment and recovery copy remains the check the PR description leaves open.
Device testing: not performed in this review.
Ready for device testing.
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
Approved at 5e55fd86c599d12d3770a4649eb8f050a8f731f0 following the current-head code review and Piotr’s report that the requested German and Arabic manual translation checks look good. The USB test build matches this PR head.
This covers the unfunded translation smoke-check scope; funded payment, refund and populated-history flows are not claimed as tested.
3 participants
Closes #1508
Twin: synonymdev/bitkit-ios#953
Refs: #1492
Description
values-ptgets European Portuguese, as in the pass and iOSpt;values-pt-rBRgets Brazilian Portuguese.USDT terms per locale
Register and the existing terms follow the 3.0.0 pass glossary. New USDT concepts:
Out of Scope
usdt__send*,usdt__recipient*,usdt__bridge_*, fee and network notes (25)usdt__error_*(19)usdt__deposit_refund*and other refund strings (12)profile__auth_approval_*/pubky_auth__*USDT address sharing (11)wallet__payment_request_*(6)subscriptions__accepted_payments,subscriptions__payment_methodsusdt__deposit_batch("Converted batch") has no clear counterpart; each locale renders it literally.usdt__maximum_total("Max total debit") is abbreviated in most locales to fit, e.g. "Max. Abbuchung", "Cargo total máx.", "Макс. списание".usdt__intro_headline("DOLLARS? YOUR CALL") is a free rendering per locale.ptstrings mix in Brazilian forms (câmera, contato).Design
N/A — no UI changes.
Preview
N/A — translation-only change.
QA Notes
Journeys
usdt-german-labels.xmlManual Tests
Automated Checks
processDevDebugResources(all locales compile)