Skip to content

Unsent manual request keeps a blocked payment reservation #1675

Open

Description

@ben-kaufman

A manual incoming Bitcoin request B reserves an allowance-ledger attempt before on-chain admission. If a retained on-chain attempt A blocks B before beforeSendAttempt, the failure handler records B as UNKNOWN even when A belongs to a different request. B has no transaction ID/payment hash and can then be blocked by PaymentAlreadyRecorded on retry.

Confirmed on master 0f44d93 by extending the existing blocked Shop recovery unit test with a real pre-dispatch rejection (callback not invoked): the expected failed reservation was instead recorded unknown. The original A recovery assertions still pass. This is inherited code, not introduced by the loaded-account filter. Reported in Android #1656 review.

Release only B's definitely undispatched reservation. Preserve A's recovery state, same-request/missing-blocker/unreadable-state uncertainty, authorization and duplicate-payment safeguards. Check the matching iOS path. Native reproduction has not been run by the author; no real funds are required.

Activity

  1. added this to the 3.2.0 milestone on Oct 23, 2026
  2. ovitrif commented on Oct 23, 2026

    @ovitrif
    Collaborator

    Triage: 3.2.0. It's a retry edge case in inherited code, found by a unit test with no native reproduction yet, and 3.1.0 ships today. The matching iOS path still needs checking.

  3. ovitrif commented on Oct 23, 2026

    @ovitrif
    Collaborator

    iOS twin: synonymdev/bitkit-ios#1106 (3.2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions