Skip to content

chore: clarify background proof failure diagnostics #1629

Open

Description

@ben-kaufman

The post-Accepted background completion boundary in AppViewModel.completeOnchainPaymentProofInBackground safely retains durable recovery when a temporary error occurs, but its warning does not distinguish a failed proof completion from a later failed subscription refresh. The latter may happen after the proof is already complete, so “Deferred … proof completion” can misdescribe the stage.

Add a concise phase-aware diagnostic and safe error classification using existing logging patterns. Do not log raw payment payloads, addresses, credentials or arbitrary exception text. Preserve cancellation propagation, durable reconciliation and the absence of financial retries. Cover failure before completion versus failure only during the subsequent subscription refresh.

Deferred LOW review finding under the repository's Review Findings policy: #1591 (comment). The crash/recovery fix itself remains in #1591.

Activity

  1. added this to the 3.1.0 milestone on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions