You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: pay allowance requests on-chain once fees count against the limits #1592
Automatic on-chain allowance payments spend a mining fee that no allowance limit counts. The SDK's allowance ledger records the request amount only, since it requires the paid amount to equal the request, and the per-payment and monthly checks in PaykitAllowanceExecutor use the same amount. This PR adds a stopgap: an automatic on-chain payment whose fee exceeds the amount stays manual. A fee up to the amount still falls outside the limits, so a contact that publishes only on-chain endpoints can make the wallet spend up to twice what the allowance shows as paid.
Expected behavior
The total an allowance can make the wallet spend, fees included, stays within what the user approved: either fees count against the per-payment and monthly limits, or automatic payments use only Lightning.
Steps to Reproduce
Grant a contact $5 a payment and $10 a month.
The contact publishes only an on-chain endpoint and sends many small requests.
Each request is paid on-chain with a Medium-rate fee; the detail sheet shows only the amounts.
changed the title [-]bug: automatic on-chain allowance fees are not counted against the allowance limits[/-][+]feat: pay allowance requests on-chain once fees count against the limits[/+]on Oct 19, 2026
Rescoped: #1340 now pays allowance requests automatically over Lightning only (6e36ce4), so on-chain fees no longer escape the limits; an on-chain request stays manual. This issue now tracks bringing on-chain auto-pay back once its fees count against the per-payment and monthly limits.
Activity
[-]bug: automatic on-chain allowance fees are not counted against the allowance limits[/-][+]feat: pay allowance requests on-chain once fees count against the limits[/+]ovitrif commentedon Oct 19, 2026
Rescoped: #1340 now pays allowance requests automatically over Lightning only (6e36ce4), so on-chain fees no longer escape the limits; an on-chain request stays manual. This issue now tracks bringing on-chain auto-pay back once its fees count against the per-payment and monthly limits.