Repository navigation
jextract/jni: Fix duplicate protocol parameter wrappers for overloads - #962
Open
sidepelican wants to merge 2 commits into
Open
sidepelican wants to merge 2 commits into
sidepelican wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a protocol is used as a parameter, jextract generates a wrapper class in Swift. The name is based on the enclosing type, method name, and parameter name.
Overloads with the same protocol parameter can therefore generate duplicate wrapper classes:
Solution
Generate the wrapper class name from the protocol types and reuse the class with the same protocol composition.
The generated class is
fileprivateand emitted once per Swift file, so different files can use the same wrapper name without conflicting.This also adds support for protocol values within tuple parameters.
Fixes #946