Repository navigation
jextract/jni: Fix protocol parameter helper naming - #960
Merged
Merged
Conversation
ktoso
approved these changes
Nov 10, 2026
Collaborator
|
Thanks! Sorry for slow reviews, I'm on holiday this week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a protocol is used as a parameter, jextract generates a wrapper class in Swift. The wrapper class name is based on the original Swift function signature, but the code that uses the wrapper refers to it by a name based on the Java method name.
This causes a naming mismatch in cases such as the following:
Solution
Use the Java-translated function signature when generating the wrapper class name, so that the declaration and its references use the same name.
Fixes #949