Repository navigation
fix(jextract/jni): preserve underlying exception in async closures - #959
Open
codingnoobno1 wants to merge 2 commits into
Open
codingnoobno1 wants to merge 2 commits into
codingnoobno1 wants to merge 2 commits into
Conversation
Future.get() reports a failed Java future as ExecutionException. Unwrap that one layer before completeExceptionally so the outer future keeps the original throwable. Fixes swiftlang#915 Co-authored-by: Cursor <cursoragent@cursor.com>
The generator check never calls future.get(). Throw ExecutionException with a RuntimeException cause and assert the outer future still reports that cause. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Java async closure completes exceptionally,
Future.get()throwsjava.util.concurrent.ExecutionException. The async JNI thunk passed that wrapper tocompleteExceptionally, so the outer future lost the original throwable.Changes
Unwrap one
ExecutionExceptioninJNIEnvironment.completeFutureExceptionallyand pass its cause tocompleteExceptionally. Other errors still go throughmakeJavaThrowable. The generated async catch calls this helper, and a jextract snapshot test covers that call.Fixes #915
Test plan
swift test --disable-xctest --disable-experimental-prebuilts --filter asyncFailurePreservesJavaExceptionCauseon Swift 6.3 (noble) and JDK 25