You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds the check runs core-test and core-format (from .github/workflows/core.yml, added by #25) to required_checks in .github/org-sync.toml[settings]. After this, a PR cannot merge while core/ fails its strict-warning build, its tests (plain and under ASan + UBSan) or clang-format. The names are the exact check-run names on #25's head commit.
Merge order: merge this only after #25. This PR is based on main, not on #25's branch, so the diff stays at one line. Until core.yml is on main, those checks never report, and requiring them would block every PR.
Adds the check run(s) core-test,core-format from .github/workflows/core.yml (added by
#25) to required_checks in .github/org-sync.toml [settings],
so a PR cannot merge with core/ failing its strict-warning build, its tests
(plain and under ASan + UBSan) or clang-format. The names are the check-run
names on #25's head commit.
Merge after #25: until core.yml is on main the check never
reports, and requiring it would block every PR.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qx5bTTkobruNZPPAguYjWa
Auto incremental reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
swarm-routing/HOPNET#25: That PR adds the workflow jobs whose names this change makes required.
Merge Risk: Minimal · previous review af2a2
Both core checks become required. Merge after #25 supplies them; its workflow conditions remain unverified.
Security architecture risk: Low · up to af2a2
The change strengthens merge requirements, but safe activation depends on deploying both check producers first. Their coverage and the recovery path if they do not report remain unverified.
Retained concerns
Low · reliability · inferred: If the expanded policy is activated before both check producers are available for governed pull requests, the merge gate can become unsatisfiable, potentially blocking corrective changes as well. The author documents the prerequisite merge order, but producer coverage and an effective recovery path are not established by the available evidence.
Security review details
Security Blast Radius
inferred — The visible change affects repository merge eligibility rather than application runtime access. The exact governed branches, check-producer identity restrictions, and bypass roles depend on external policy configuration that is not available.
Trust Boundaries and Controls
inferred — The PR strengthens the declared gate while retaining the existing external policy-management boundary. The available comparison does not establish a newly introduced bypass or authority expansion; it also does not verify which check-producing identities the applied policy trusts.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly summarizes the main change: requiring the core checks.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between eb98b69 and af2a2d8.
Files selected for processing: 1
.github/org-sync.toml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the check runs
core-testandcore-format(from.github/workflows/core.yml, added by #25) torequired_checksin.github/org-sync.toml[settings]. After this, a PR cannot merge whilecore/fails its strict-warning build, its tests (plain and under ASan + UBSan) or clang-format. The names are the exact check-run names on #25's head commit.Merge order: merge this only after #25. This PR is based on
main, not on #25's branch, so the diff stays at one line. Untilcore.ymlis onmain, those checks never report, and requiring them would block every PR.Checks
tomllibparses the file:required_checks = ['check / org-sync', 'headers / licence', 'title / title', 'core-test', 'core-format'].gh api repos/swarm-routing/HOPNET/commits/<#25 head>/check-runs:core-testandcore-format, both success. feat(core): the intra-zone half — internal ants, intrart, eqs. 4.1-4.3, neighbour discovery #25 keeps both job names unchanged after it drops the vendored swarm-core copy.Generated by Claude Code
Summary by CodeRabbit
core-testandcore-formatto the required checks.