Skip to content

chore(settings): require the core checks - #26

Merged
danieljoppi merged 2 commits into
mainfrom
claude/require-core-checks
Nov 10, 2026
Merged

danieljoppi merged 2 commits into
mainfrom
claude/require-core-checks

Conversation

@danieljoppi

@danieljoppi danieljoppi commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds the check runs core-test and core-format (from .github/workflows/core.yml, added by #25) to required_checks in .github/org-sync.toml [settings]. After this, a PR cannot merge while core/ fails its strict-warning build, its tests (plain and under ASan + UBSan) or clang-format. The names are the exact check-run names on #25's head commit.

Merge order: merge this only after #25. This PR is based on main, not on #25's branch, so the diff stays at one line. Until core.yml is on main, those checks never report, and requiring them would block every PR.

Checks


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Added core-test and core-format to the required checks.

Adds the check run(s) core-test,core-format from .github/workflows/core.yml (added by
#25) to required_checks in .github/org-sync.toml [settings],
so a PR cannot merge with core/ failing its strict-warning build, its tests
(plain and under ASan + UBSan) or clang-format. The names are the check-run
names on #25's head commit.

Merge after #25: until core.yml is on main the check never
reports, and requiring it would block every PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qx5bTTkobruNZPPAguYjWa
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The org-sync configuration now requires the core-test and core-format checks. The existing required checks remain unchanged.

Changes: Required checks

Layer / File(s) Summary
Add core checks
.github/org-sync.toml
The required checks list now includes core-test and core-format. The existing required checks remain in the list.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · previous review af2a2

Both core checks become required. Merge after #25 supplies them; its workflow conditions remain unverified.

Security architecture risk: Low · up to af2a2

The change strengthens merge requirements, but safe activation depends on deploying both check producers first. Their coverage and the recovery path if they do not report remain unverified.

Retained concerns

  • Low · reliability · inferred: If the expanded policy is activated before both check producers are available for governed pull requests, the merge gate can become unsatisfiable, potentially blocking corrective changes as well. The author documents the prerequisite merge order, but producer coverage and an effective recovery path are not established by the available evidence.
Security review details

Security Blast Radius

  • inferred — The visible change affects repository merge eligibility rather than application runtime access. The exact governed branches, check-producer identity restrictions, and bypass roles depend on external policy configuration that is not available.

Trust Boundaries and Controls

  • inferred — The PR strengthens the declared gate while retaining the existing external policy-management boundary. The available comparison does not establish a newly introduced bypass or authority expansion; it also does not verify which check-producing identities the applied policy trusts.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main change: requiring the core checks.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between eb98b69 and af2a2d8.

Files selected for processing: 1

  • .github/org-sync.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

@danieljoppi
danieljoppi merged commit 5f1c12c into main Nov 10, 2026
8 checks passed
@danieljoppi
danieljoppi deleted the claude/require-core-checks branch November 10, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants