Repository navigation
refactor(input): clarify modal precedence and typed UI action contract - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #69.
Summary
ui.Actionandui.ActionKindininternal/ui/action.go:ActionToggle,ActionStop,ActionNext,ActionSeekForward,ActionSeekBackward,ActionSetTheme,ActionCycleCountry.newShell(internal/app/controls.go) to handle actions via a clean typed switch without prefix string parsing.handleKeyinto an explicit 4-layer modal precedence architecture:tryModalKey): Application modals and text inputs (URL viewer, chapters, onboarding, confirmation, add feed URL, search modal) consume keystrokes exclusively, preventing accidental playback mutations.Model.Busy()): UI presentation modals (column filter, settings theme picker, help popup, message viewer) consume their keys via delegation.handleActionKey): Application contextual and transport actions (volume, seek, play/pause, queue, subscribe, details).delegate): Default UI panel and list navigation.internal/app/modal_precedence_test.goverifying input isolation, modal precedence, quit delegation, and episode identity retention across all modals.docs/code-flow.mddocumenting the input precedence layers and typed action contract.