Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Hardware-dependent decoding and presentation need human validation beyond the reported single-device, 8-bit macOS case, particularly for 10-bit VP9 and other Apple platforms.
No open issues 🎉
What changed in this PR
Adds VideoToolbox hardware decoding for supported VP9 streams within the existing software playback host, retaining libavcodec fallback and the current presentation path.
Changes:
- Synthesizes VP9 configuration records and supports hardware sessions for 8-bit profile 0 and 10-bit profile 2, both 4:2:0.
- Opens software fallback and cleans up failed decoders before packet reading begins.
- Adds configuration, fallback, and load/reload regressions; updates playback documentation.
| File | Description |
|---|---|
| Tests/AetherEngineTests/SoftwareDecoderSelectionTests.swift | Tests VP9 configuration, selection, and fallback cleanup. |
| Tests/AetherEngineTests/ActiveVideoDecoderTests.swift | Checks VP9 decoder identity and frames across load/reload. |
| Sources/AetherEngine/Native/SoftwarePlaybackHost.swift | Integrates VP9 hardware selection and software fallback. |
| Sources/AetherEngine/Decoder/VideoToolboxVideoFormat.swift | Builds codec descriptions and validates VP9 configurations. |
| Sources/AetherEngine/Decoder/VideoDecoderTypes.swift | Adds configuration and hardware-availability errors. |
| Sources/AetherEngine/Decoder/VideoDecoderOpener.swift | Handles preferred decoder opening and fallback cleanup. |
| Sources/AetherEngine/Decoder/HardwareVideoDecoder.swift | Enables VP9 registration and hardware session setup. |
| README.md | Updates the VP9 support summary. |
| docs/formats.md | Documents supported VP9 formats and fallback behavior. |
| docs/architecture.md | Explains VP9 integration with the software host. |
| CHANGELOG.md | Records VP9 hardware decoding support. |
Review effort: Balanced
jonluca
force-pushed
the
feat/vp9-videotoolbox-decoding
branch
from
October 25, 2026 18:28
66b3b62 to
df8fc1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use VideoToolbox hardware decoding for supported VP9 streams while keeping the software playback host's presentation path. VP9 previously always used libavcodec even on hardware that can decode it directly; AVPlayer's HLS route remains unsuitable for VP9.
What changed
vpcCrecord from FFmpeg's probed profile, depth, chroma, range and color parameters.Test plan
Scripts/fetch-fixtures.shforvp9.webm.aetherctl play --seconds 4 Fixtures/vp9.webmpasses: VideoToolbox VP9 opens, frames are decoded, and the clock remains at 1.00x. This is an output/clock smoke check without a bound onscreen surface.AetherEnginebuilds with-warnings-as-errors.python3 Scripts/check-doc-links.pyandgit diff --checkpass.Checklist
CHANGELOG.mdupdated