Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The cache keys consistently reflect extraction parameters, preserve existing limits, and have focused regression coverage with no blocking issues identified.
No open issues 🎉
What changed in this PR
Fixes still-extraction cache reuse so one FrameExtractor can serve multiple sizes without returning incorrectly sized images, while keeping adjacent snapshot requests distinct.
Changes:
- Include requested dimensions and exact snapshot times in cache keys.
- Preserve thumbnail time buckets and existing per-mode cache limits.
- Add regression tests and document the corrected cache behavior.
| File | Description |
|---|---|
Tests/AetherEngineTests/FrameCacheTests.swift |
Tests exact snapshot times, dimension variants, and shared-limit eviction. |
Sources/AetherEngine/FrameExtractor/FrameExtractor.swift |
Passes dimensions to cache lookups and inserts; clarifies a cache-bypass comment. |
Sources/AetherEngine/FrameExtractor/FrameCache.swift |
Adds dimension-aware keys and exact snapshot-time matching. |
docs/api.md |
Documents size-aware caching and per-mode time matching. |
CHANGELOG.md |
Records the still-extraction cache fixes. |
Review effort: Balanced
jonluca
force-pushed
the
fix/frame-cache-request-identity
branch
from
October 25, 2026 18:27
75803c5 to
70b8883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requesting another size from the same still extractor can return the first image's dimensions, and nearby snapshot requests can return a cached frame from the wrong side of a frame boundary. Cache keys now include requested dimensions and preserve exact snapshot request times.
What changed
Test plan
swift build --target AetherEngine -Xswiftc -warnings-as-errors, the documentation link checker andgit diff --checkpassed.Related: #871 adds a preview mode independently; both PRs touch the shared cache implementation and may need a small reconciliation depending on merge order.
Checklist