Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped fix protects the port read without introducing nested locking or changing explicit overrides, and no blocking issues remain.
No open issues 🎉
What changed in this PR
This PR fixes an unsynchronized port read in the CLI’s HLS fixture server while preserving explicit redirect-port overrides.
Changes:
- Reads the default redirect port under the lifecycle lock and makes the stored port private.
- Documents the synchronization behavior in the CLI guide and changelog.
| File | Description |
|---|---|
Sources/aetherctl/HLSFixture.swift |
Synchronizes the default redirect-port read and restricts port visibility. |
docs/cli.md |
Explains how redirects read the bound port when no override is supplied. |
CHANGELOG.md |
Records the synchronization fix and unchanged override behavior. |
Review effort: Balanced
jonluca
force-pushed
the
fix/hls-fixture-port-lock
branch
from
October 25, 2026 18:21
1036586 to
e17499b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The HLS fixture's request workers read the bound port without synchronization while
stop()resets it under the server lock. Read the redirect's default port under that same lock and keep the stored port private. Explicit redirect-port overrides keep their current behavior.Test plan
swift build --target aetherctl --disable-automatic-resolution --jobs 4succeeds with the resolved pins and an isolated scratch directory. It reports the existing unusedplacementbinding inScrubPreviewCmd.swift; this change adds no warning.git diff --checkpass.Checklist