Repository navigation
chore(api): delete unused Zendesk support executor - #91
Draft
tomdmeredith wants to merge 1 commit into
Draft
tomdmeredith wants to merge 1 commit into
tomdmeredith wants to merge 1 commit into
Conversation
The live support path uses zendesk_read_executor. Remove the superseded executor, its tests, and the ticket_in_scope helper that only that executor called. Co-authored-by: tomdmeredith <tomdmeredith@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly cleanup only. Removes the superseded Zendesk support executor that production does not import. Draft; do not merge and do not deploy.
The live support path stays on
packages/api/routes/support_execute.py, which callsservices.zendesk_read_executor. Ticket scope checks on that path still go throughensure_ticket_access.Deleted
packages/api/services/zendesk_support_executor.pypackages/api/tests/test_zendesk_support_executor.pyticket_in_scopeinpackages/api/services/support_connection_registry.pytest_ticket_in_scope_requires_all_configured_constraintsinpackages/api/tests/test_support_connection_registry.py(the only test that coveredticket_in_scope)Kept
packages/api/services/zendesk_read_executor.pyensure_ticket_accessandticket_is_allowedinsupport_connection_registry.pypackages/api/routes/support_execute.pyTest plan
pytest tests/test_support_connection_registry.py tests/test_zendesk_read_executor.py tests/test_support_execute.pyfrompackages/api(16 passed)ruff checkon the edited registry and its test filepackages/apipytest also ran. Failures are outside this change (probe, score, proxy, and auth 401s).support_connection_registry.pyalready failsblack --checkonmain; this diff does not reformat it.