Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #934 and #935.
Consecutive comments before
ELSE,THEN,END, andGRANT/REVOKEkeywords could be emitted in reverse order because only the last comment received the keyword anchor:Comments before
ENDcould also move into a nested CASE, or out intoFROMwhen the last branch was a function call:The formatter now anchors every comment in a consecutive group to the same keyword and keeps mixed block/line comments on the same side of their node. Comments before a CASE's
ENDare attached to that CASE and emitted after its complete final branch. CASE/END matching uses actual CASE nodes, parenthesis depth, and field-name context so names such ast.endand subquery aliases do not change the closing boundary.Six new regression tests cover both layouts, mixed comment groups, GRANT/REVOKE, nested CASEs in THEN and ELSE, compound final expressions, keyword names, and idempotence.
Validation:
cargo test -p pgls_pretty_print— 759 tests passed.cargo test -p pgls_pretty_print --test option_matrix -- --ignored— fixtures and PostgreSQL regression corpus across all 32 layout combinations.cargo clippy --all-targets --all-features.cargo fmt --all -- --checkandgit diff --check.