Repository navigation
Conversation
The parse results and the tree-sitter trees of a document's statements move into server/document_cache, behind a DocumentCache that the document owns. No behaviour changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1002. Part of the rebuild described in #997 (point 4: one cache per document, in one module).
A move without behaviour changes. The parse results and the tree-sitter trees of a document's statements move from
server/pg_query.rsandserver/tree_sitter.rsintoserver/document_cache/{parse,tree}.rs, behind aDocumentCachethat theDocumentowns:parse,plpgsql_parse,embeddedandtreelook up or compute what is cached for a statement;retain_statementsdrops what was cached for the statements that are no longer in the document.The mappers and
Document::update_contentcall these instead of reaching into the two stores. The psql parameter conversion thatpg_query.rsre-exported is imported frompgls_lexerdirectly.The next PRs add what depends on the settings and the database to this module (the analysis, the walk checkpoints, the resolved references), under one key and one invalidation rule.
Tests
pgls_workspaceand clippy pass unchanged.