Repository navigation
Move sqd-network to main with the dial-failure lookup fixes - #84
Merged
Merged
Conversation
11f4230 is a commit of the closed sqd-network#216 branch. Its retries stop after a lookup that cannot find a worker that is still offline, and it lacks the open_stream hang fixes from sqd-network#217. main vendors libp2p-stream, so the patch for the libp2p fork goes away. The shared DataChunk parser in sqd-messages 3.1.0 reads everything after the second dash as the hash, so the router now strips /blocks.parquet from an object key before it parses the chunk id. Bump pings-collector to 2.9.1, logs-collector to 2.5.1 and portal-logs-collector to 1.1.7. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mo4islona
force-pushed
the
sqd-network-dial-failure-lookup
branch
from
October 15, 2026 22:36
8571ad4 to
f640b38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves sqd-network from
11f4230, a commit of the closed subsquid/sqd-network#216 branch, toe1460fdonmain, which has subsquid/sqd-network#217.Why
11f4230looks a worker up again after a failed dial, but it stops retrying when a lookup cannot find a worker that is still offline: the next dial fails withNoAddresses, which it does not retry. It also lacks theopen_streamhang fixes in the vendoredlibp2p-stream. The pings collector and the logs collector keep connections to all workers, so both need the full fix.Changes
e1460fdfor all three crates.sqd-messagesis now 3.1.0.[patch.crates-io]for the libp2p fork is removed: sqd-network now uses libp2p from crates.io.DataChunk::newtakes&strand validates the hash, andQueryhas a newchunk_versionfield. The collectors do not store that field, and query signatures do not cover it./blocks.parquetfrom an object key before it parses the chunk id. The sharedDataChunkparser reads everything after the second dash as the hash, so it rejects the full key, which the old parser accepted.Testing
cargo fmt --all -- --check,cargo clippy --workspace --all-targets --locked -- -D warningsandcargo test --workspace --lockedpass.🤖 Generated with Claude Code