Skip to content

Move sqd-network to main with the dial-failure lookup fixes - #84

Merged
mo4islona merged 1 commit into
mainfrom
sqd-network-dial-failure-lookup
Oct 15, 2026
Merged

mo4islona merged 1 commit into
mainfrom
sqd-network-dial-failure-lookup

Conversation

@mo4islona

@mo4islona mo4islona commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Moves sqd-network from 11f4230, a commit of the closed subsquid/sqd-network#216 branch, to e1460fd on main, which has subsquid/sqd-network#217.

Why

11f4230 looks a worker up again after a failed dial, but it stops retrying when a lookup cannot find a worker that is still offline: the next dial fails with NoAddresses, which it does not retry. It also lacks the open_stream hang fixes in the vendored libp2p-stream. The pings collector and the logs collector keep connections to all workers, so both need the full fix.

Changes

  • sqd-network e1460fd for all three crates. sqd-messages is now 3.1.0.
  • The [patch.crates-io] for the libp2p fork is removed: sqd-network now uses libp2p from crates.io.
  • Test-only updates for the new API: DataChunk::new takes &str and validates the hash, and Query has a new chunk_version field. The collectors do not store that field, and query signatures do not cover it.
  • The router strips /blocks.parquet from an object key before it parses the chunk id. The shared DataChunk parser reads everything after the second dash as the hash, so it rejects the full key, which the old parser accepted.
  • pings-collector 2.9.1, logs-collector 2.5.1, portal-logs-collector 1.1.7, so the release does not overwrite published tags.

Testing

cargo fmt --all -- --check, cargo clippy --workspace --all-targets --locked -- -D warnings and cargo test --workspace --locked pass.

🤖 Generated with Claude Code

11f4230 is a commit of the closed sqd-network#216 branch. Its retries stop
after a lookup that cannot find a worker that is still offline, and it lacks
the open_stream hang fixes from sqd-network#217. main vendors libp2p-stream,
so the patch for the libp2p fork goes away.

The shared DataChunk parser in sqd-messages 3.1.0 reads everything after the
second dash as the hash, so the router now strips /blocks.parquet from an
object key before it parses the chunk id.

Bump pings-collector to 2.9.1, logs-collector to 2.5.1 and
portal-logs-collector to 1.1.7.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mo4islona
mo4islona force-pushed the sqd-network-dial-failure-lookup branch from 8571ad4 to f640b38 Compare October 15, 2026 22:36
@mo4islona
mo4islona merged commit e84b187 into main Oct 15, 2026
3 checks passed
@mo4islona
mo4islona deleted the sqd-network-dial-failure-lookup branch October 15, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant