Repository navigation
fix(deps): keep a single Strapi in the workspace - #260
Merged
Merged
Conversation
After the playgrounds moved to Strapi 5.57 (#242), the lockfile still held a complete 5.52 install, kept alive by the memory provider's auto-installed `@strapi/strapi` peer, which Dependabot never moves. Strapi core resolves its built-in plugins through the workspace's hoisted node_modules, so a 5.57 app sometimes loaded the 5.52 content-type-builder and failed to boot: TypeError: strapi.ai.admin.isEnabled is not a function in whichever CI job happened to resolve it - e2e_memory, e2e_redis or boot_smoke on Node 26, on otherwise unrelated pull requests. `pnpm dedupe` collapses every @strapi package to 5.57.0. It adds no package version that was not already in the lockfile and removes 158 duplicates. scripts/check-single-strapi.cjs, run by test:deps, fails when @strapi/strapi or @strapi/core appear at more than one version, and says to run `pnpm dedupe`. It fails on the previous lockfile.
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Since #242 moved the playgrounds to Strapi 5.57, CI has been failing intermittently on unrelated PRs. #248, #253 and #255 each failed one job:
e2e_memory,e2e_redisorboot_smokeon Node 26. All three failed with:Cause: the lockfile held two complete Strapi installs, 5.52.0 and 5.57.0.
@strapi/strapi ^5.0.0peer, still locked at 5.52.0. Dependabot moves the playgrounds' pinned versions, not a locked peer.node_modules, not through its own dependencies.Fix:
pnpm dedupe. Every@strapi/*package is now at 5.57.0 only.package.jsonrange changes, so nothing reaches users.Guard: a new
scripts/check-single-strapi.cjs, run bytest:deps, fails when@strapi/strapior@strapi/coreappear at more than one version, and says to runpnpm dedupe.FAIL @strapi/strapi: 2 versions (5.52.0, 5.57.0).ok.Tests
test:boot: both playgrounds boot under real Node resolution. This is the job that failed on fix(admin): purge the open entry from the edit view, and let the purge button be used twice #253.test:e2e:memory: 135/135, run twice.test:e2e:redis: 135/135.test:admin: 13/13.test:lint,test:deps: green.Notes for the reviewer
Checklist
main.