Repository navigation
ci(rust): bump napi-derive from 3.6.12 to 3.6.13 - #184
Conversation
strandly-the-agent
left a comment
There was a problem hiding this comment.
Verdict: Breaking: napi-derive 3.6.13 generates code that calls napi::bindgen_prelude::defer_native_borrow_scope, which only exists in napi 3.15.0; this PR leaves napi at 3.14.2 so the node feature does not compile (CI Rust jobs are red for this reason).
| Package | From → To | Tier | Scope |
|---|---|---|---|
| napi-derive (+ napi-derive-backend 6.1.5 → 6.1.6) | 3.6.12 → 3.6.13 | patch | build-time proc-macro behind node feature (Cargo.toml:27), direct, lockfile-only |
Breaking for this repo: src/js.rs:243 and :420 (#[napi] items): cannot find NativeBorrowScopeRelease in bindgen_prelude / cannot find function defer_native_borrow_scope. The emitted code comes from napi-derive-backend 6.1.6 (fn.rs), and the symbols were added in napi 3.15.0. Fix: merge #182 (napi 3.15.0) first, then rebase this one (@dependabot rebase); or close this and let the next napi group PR carry both. No @dependabot ignore needed.
Tests: cargo check --features node --locked ✗ 3 errors (merge-base control ✓) · default-feature cargo test ✓ (identical counts to control) · reproduces CI: Rust (ubuntu/macos/windows) all FAILURE
Supply chain: no flags: no new crates, not yanked, MSRV 1.88 unchanged, published 2026-10-22 (5 days). Changelog for 3.6.13 is just "update Cargo.toml dependencies"; the real change is in napi-derive-backend 6.1.6.
Details
Suggestion for the repo: group napi, napi-derive, napi-build, napi-sys in .github/dependabot.yml so these always move together (napi-rs releases them in lockstep).
Sources: crates.io metadata; crate tarball diffs of napi-derive 3.6.12→3.6.13 and napi-derive-backend 6.1.5→6.1.6 (saved as evidence under strands-agents/shell/pr/184/), napi 3.14.2→3.15.0 diff showing the added symbols.
fccc4cf to
c1b1e78
Compare
|
@dependabot rebase |
|
@dependabot recreate |
Bumps [napi-derive](https://github.com/napi-rs/napi-rs) from 3.6.12 to 3.6.13. - [Release notes](https://github.com/napi-rs/napi-rs/releases) - [Commits](napi-rs/napi-rs@napi-derive-v3.6.12...napi-derive-v3.6.13) --- updated-dependencies: - dependency-name: napi-derive dependency-version: 3.6.13 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
c1b1e78 to
d6f21db
Compare
Bumps napi-derive from 3.6.12 to 3.6.13.
Release notes
Sourced from napi-derive's releases.
Commits
d9cb526chore: release (#3575)d3d4536chore(deps): update oxc-node to v1 (#3635)ebdac4bchore: add emnapi version72eafbechore(deps): update release-plz/action action to v0.5.144 (#3633)bafc7dbchore(release): publish8603be9chore(deps): update dependency oxfmt to ^0.74.0 (#3629)3caf68echore(deps): update dependency vite to v8.3.3 [security] (#3632)0ad70a7fix(cli): take over the WASI flavor of a binding a postbuild fallback swaps i...5547cd4fix(cli): resolve null when the incarnation probe's spawn throws synchronousl...b3bb7a4feat(napi): cancel a ReadableStream through its Reader, and fix ReadableStrea...