Skip to content

ci: make the samples manifest a checked build contract - #334

Merged
morganwilliscloud merged 7 commits into
strands-agents:mainfrom
tmoreton:agent-tasks/examples-manifest
Oct 29, 2026
Merged

morganwilliscloud merged 7 commits into
strands-agents:mainfrom
tmoreton:agent-tasks/examples-manifest

Conversation

@tmoreton

@tmoreton tmoreton commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • make samples.json a deterministic build contract owned by this repository
  • add --check mode and a pull request workflow so catalog drift is caught before merge
  • refresh the generated catalog to include all 90 current samples while preserving the version 1 fields used by downstream consumers
  • improve generated titles and descriptions, and fix two README references that render incorrectly as documentation

Why

The Strands documentation site consumes this manifest and the referenced README or notebook content during its build. Keeping generation and validation in the samples repository means additions and edits remain owned here, while downstream sites avoid hand-maintained copies.

The manifest remains version 1, so id, categoryLabel, tags, url, and notebook metadata are retained for compatibility. This is build-time data only and adds no runtime service or dependency.

Testing

  • node --check generate-samples-manifest.mjs
  • node generate-samples-manifest.mjs --check
  • git diff --check
  • validated 90 samples across 10 categories with unique IDs, paths, and generated slugs; existing version 1 fields and notebook metadata are preserved
  • built the harness documentation from commit 2c6692a9c095120a1f662db4144da60ac40d8776: 90 guides and 1,532 HTML files with no broken links
  • ran the harness sample-guide tests: 23 passed

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Latest scan for commit: f56889f | Updated: 2026-10-29 20:45:05 UTC

✅ Security Scan Report (PR Files Only)

Scanned Files

  • .github/workflows/samples-manifest.yml
  • generate-samples-manifest.test.mjs
  • python/01-learn/10-agents-as-tools/README.md
  • python/04-industry-use-cases/finance/personal-finance-assistant/README.md
  • CONTRIBUTING.md
  • generate-samples-manifest.mjs
  • python/04-industry-use-cases/software-engineering/aws-assistant-mcp/README.md
  • python/07-ux-demos/slack-assistant/README.md
  • samples.json

Security Scan Results

Critical High Medium Low Info
0 0 0 0 0

Threshold: High

No security issues detected in your changes. Great job!

This scan only covers files changed in this PR.

@tmoreton tmoreton changed the title Agent tasks/examples manifest ci: make the samples manifest a checked build contract Oct 21, 2026
@tmoreton
tmoreton marked this pull request as draft October 21, 2026 23:20
@tmoreton
tmoreton marked this pull request as ready for review October 22, 2026 00:14
@morganwilliscloud
morganwilliscloud merged commit 2776a90 into strands-agents:main Oct 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants