Repository navigation
3.1r1: a section whose only test is unnumbered is that test - #72
Open
jadamcrain wants to merge 2 commits into
Open
jadamcrain wants to merge 2 commits into
jadamcrain wants to merge 2 commits into
Conversation
18 sections held a single unnumbered test, lettered a and titled Test Procedure, e.g. 8.6.1a under 8.6.1 Restart. Each is now one test with the section's number and title: 8.2.4, 8.2.6, 8.4.4, 8.5.1, 8.5.6, 8.6.1 to 8.6.3, 8.7.2, 8.9.1, 8.9.2, 9.5.4, 10.3.2 to 10.3.4 and 10.4.2 to 10.4.4. A section now keeps its sections and tests in the order the tree gives them, rather than listing its sections first, so that 8.6.1 to 8.6.3 still run and are listed and reported before 8.6.4. A test checks every section's children are in the order of their ids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
18 sections of the 3.1r1 tree held a single unnumbered test, lettered
aand titled "Test Procedure" (e.g.8.6.1aunder 8.6.1 Restart). Each is now one test with the section's number and title:8.2.4, 8.2.6, 8.4.4, 8.5.1, 8.5.6, 8.6.1–8.6.3, 8.7.2, 8.9.1, 8.9.2, 9.5.4, 10.3.2–10.3.4, 10.4.2–10.4.4.
Sections whose only test is numbered (6.1 → 6.1.2 and the like) and sections with several unnumbered tests are unchanged.
Order. A section used to list its subsections before its own tests, which would have moved the folded 8.2.4, 8.5.1 and 8.6.1–8.6.3 after their sibling sections when running, describing and reporting.
api.sectionnow keeps its children in the order given (TestSection.subElements), and the runner,Revision.flatMapProceduresand the report walk that order (Report.Sectionholdschildren). A new test inProcedureConfigurationTestchecks every section's children are in the order of their ids; it fails without the change (8.2.5 before 8.2.4).Docs. The id rule in the README,
docs/manual-testing.mdand the tree's doc comment covers the exception.Results. Results saved under the old ids (
3.1r1/L<n>/8.6.1a/and so on) aren't read under the new ones: rerun those tests. The lettered ids were never released.