Repository navigation
Letter the tests 3.1r1 doesn't number - #69
Merged
Merged
Conversation
A test 3.1r1 leaves unnumbered was named after its section and its place with a dash, 8.6.5-2, and 8.21's and 8.22's reruns of 8.13's and 8.14's tests after both sections, 8.22-8.14.2-3. Now each has its section's number followed by a letter for its place among the section's unnumbered tests, in document order: 8.6.5b, 8.22c. Ids no longer refer to other sections, and a letter can't be mistaken for one of 3.1r1's own numbers: 8.22a sits beside 8.22.1. No section has more than 16 such tests, and a test checks each section's letters run a, b, c and on without a gap. The double-bit reruns' titles say which test each runs, e.g. "Double-bit Input Change, Qualifier 0x06 (as 8.14.2c)", in place of 8.14's title with ", with double-bit inputs". Every procedure's steps are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New ids
3.1r1 leaves 103 tests unnumbered. Each one now gets its section's number followed by a letter for its place among the section's unnumbered tests, in document order:
New titles for the double-bit reruns
The 20 double-bit reruns now say which test each one runs. For example, "Double-bit Input Change, Qualifier 0x06 (as 8.14.2c)" replaces "Binary Input Change, Qualifier 0x06, with double-bit inputs".
Other mentions of the ids
Comments, test names, option descriptions, the README and
docs/manual-testing.mdall use the new ids, and their explanations of the scheme describe the letters.Checks
I compared a dump of both revisions' trees, every procedure's
-describeoutput, the disabled lists andRevision.validate, before and after, with the new ids mapped back to the old ones. It covered every subset level in three configurations. The only differences are the 20 new titles.mvn testpasses.Saved results
Results saved under the old ids don't count in a report under the new ones. No release has 3.1r1 yet, so this only affects local runs, which need running again. stepfunc/dnp3's conformance
device.ininames some of these ids in a comment; that gets updated with its next dnp3c pin.