Skip to content

Share the small helpers procedures repeated - #68

Merged
jadamcrain merged 1 commit into
mainfrom
smaller-helpers
Oct 14, 2026
Merged

jadamcrain merged 1 commit into
mainfrom
smaller-helpers

Conversation

@jadamcrain

Copy link
Copy Markdown
Member

Item 8 of #59.

Changes

  • Trivial steps. TestStep(description)(act) builds a step that does one thing and defers no checks. It replaces the TestStep blocks written out for each such step. The description is still evaluated each time it's used.
  • Plugin actions. PluginSteps.action is now shared. The procedures that wrote their own version use it, and 3.1r1's 8.24 uses PluginSteps.setFlagsNormal. Network's set-up and restore steps aren't changed, because they close the connection first.
  • Level 1 tests. 3.1r1's 8.14.2-1 is now StaticInputs.LevelOneWithoutReads for events, with its own text for the last step. It was a copy of that class.
  • Count-qualifier tests. The four count-qualifier event tests share their steps through EventTest.countReads. Each test still gives the step numbers its text uses. That sharing stays within 3.1r1, as the issue's "Not doing" list asks.
  • IIN checks. IIN.objectErrors is the IIN2.1-or-IIN2.2 check, defined once. IIN.errors replaces the masks that also count IIN2.0.
  • Result files. ResultFiles names the files a run writes.
  • Saved results. SavedResult holds a procedure's ProcedureOutcome as it was saved, in place of TestResult. The file's format is unchanged, so existing results still read.
  • Range headers. ObjectHeader.startStop builds a start/stop header without objects.

Checks

  • -describe dump. I compared a dump of both revisions' trees, every procedure's -describe output, the disabled lists and Revision.validate, at each subset level, before and after. It's identical except for 3.1r1's 8.24 step that sets the flags normal. That step now says what normal is: "ONLINE set, all others clear".
  • Protocol corpus. The seeded protocol parse corpus is unchanged.
  • Tests. mvn test passes.

- TestStep(description)(act) makes a step that does one thing and
  defers no checks, in place of a TestStep written out each time.
- PluginSteps.action is shared, and the procedures that wrote their
  own use it, as 3.1r1's 8.24 now uses PluginSteps.setFlagsNormal.
- 3.1r1's 8.14.2-1 is LevelOneWithoutReads for events, with its own
  last step, and the four count-qualifier event tests share their
  steps, each still numbering them as its text does.
- IIN.objectErrors is the IIN2.1-or-IIN2.2 check, and IIN.errors is
  used where IIN2.0 counts too.
- ResultFiles names the files a run writes.
- SavedResult holds a procedure's ProcedureOutcome as saved, in place
  of TestResult; the file's format is unchanged.
- ObjectHeader.startStop builds a start/stop header without objects.

Every procedure's steps are unchanged, except that 8.24's step that
sets the flags normal says what normal is: ONLINE set, all others clear.

Part of #59.
@jadamcrain
jadamcrain merged commit 001b207 into main Oct 14, 2026
5 checks passed
@jadamcrain
jadamcrain deleted the smaller-helpers branch October 14, 2026 22:41
@jadamcrain jadamcrain mentioned this pull request Oct 14, 2026
8 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant