Repository navigation
Share the small helpers procedures repeated - #68
Merged
Merged
Conversation
- TestStep(description)(act) makes a step that does one thing and defers no checks, in place of a TestStep written out each time. - PluginSteps.action is shared, and the procedures that wrote their own use it, as 3.1r1's 8.24 now uses PluginSteps.setFlagsNormal. - 3.1r1's 8.14.2-1 is LevelOneWithoutReads for events, with its own last step, and the four count-qualifier event tests share their steps, each still numbering them as its text does. - IIN.objectErrors is the IIN2.1-or-IIN2.2 check, and IIN.errors is used where IIN2.0 counts too. - ResultFiles names the files a run writes. - SavedResult holds a procedure's ProcedureOutcome as saved, in place of TestResult; the file's format is unchanged. - ObjectHeader.startStop builds a start/stop header without objects. Every procedure's steps are unchanged, except that 8.24's step that sets the flags normal says what normal is: ONLINE set, all others clear. Part of #59.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 8 of #59.
Changes
TestStep(description)(act)builds a step that does one thing and defers no checks. It replaces theTestStepblocks written out for each such step. The description is still evaluated each time it's used.PluginSteps.actionis now shared. The procedures that wrote their own version use it, and 3.1r1's 8.24 usesPluginSteps.setFlagsNormal. Network's set-up and restore steps aren't changed, because they close the connection first.StaticInputs.LevelOneWithoutReadsfor events, with its own text for the last step. It was a copy of that class.EventTest.countReads. Each test still gives the step numbers its text uses. That sharing stays within 3.1r1, as the issue's "Not doing" list asks.IIN.objectErrorsis the IIN2.1-or-IIN2.2 check, defined once.IIN.errorsreplaces the masks that also count IIN2.0.ResultFilesnames the files a run writes.SavedResultholds a procedure'sProcedureOutcomeas it was saved, in place ofTestResult. The file's format is unchanged, so existing results still read.ObjectHeader.startStopbuilds a start/stop header without objects.Checks
-describedump. I compared a dump of both revisions' trees, every procedure's-describeoutput, the disabled lists andRevision.validate, at each subset level, before and after. It's identical except for 3.1r1's 8.24 step that sets the flags normal. That step now says what normal is: "ONLINE set, all others clear".mvn testpasses.