Repository navigation
Remove unused code and API - #63
Merged
Merged
Conversation
- TestProcedure.mandatoryAt and Revision.unmetMandatory, with their branches in validate and -disabled: no procedure is mandatory. - 3.1r1's notYet, and the text in its tree, the README and the docs that says some 3.1r1 tests aren't implemented: all are. A test now checks that none is incomplete. - The supports.noClassAssignment option, which no procedure reads. - Harness.legacyNotice, the report's notice of dnp3c 0.1.0's results folders, and Report.create's notices parameter that only it used. - Parameters every caller gave the same value: LinkWriter.write's isMaster, readAllResponses's func, and checkSolicited's function. - FrameValidator.function, TypeTraits.CTOEvent, the UInt* min and max values, Fields.index8 and IIN.startupBits. - PrefixedPayload's constructors other than the case classes'. - runSteps's branches for an incomplete or disabled procedure, which the runner skips before running its steps. The tests' Run helper refuses a disabled definition likewise. The README describes both revisions. Every procedure's -describe output, the trees and the disabled lists are unchanged. Part of #59.
This was referenced Oct 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 4 of #59.
Removed
TestProcedure.mandatoryAtandRevision.unmetMandatory, with their branches inRevision.validateand-disabled. Nothing set them.notYetinv31r1/Tree.scala, and the text in the tree, the README anddocs/manual-testing.mdsaying some 3.1r1 tests aren't implemented. All of them are, and a new test checks that none is incomplete. The README's "Test procedures" section now describes both revisions.supports.noClassAssignment, which no procedure reads.Harness.legacyNotice, the report's notice about dnp3c 0.1.0's results folders, along withReport.create'snoticesparameter, which only it used, and the docs that described it.LinkWriter.write'sisMasterTestDriver.readAllResponses'sfuncTestDriver.checkSolicited'sfunction, whose only non-default caller wasreadAllResponsesFrameValidator.functionTypeTraits.CTOEvent(Group2Var3 is a plainEvent)UInt*objects'minandmaxFields.index8IIN.startupBitsPrefixedPayloadconstructors: every one except the case classes' own.TestRunner.runSteps: the ones for an incomplete or disabled procedure. The runner skips those before running any steps. The tests'Runhelper now refuses a disabled definition too.Checks
The trees, every procedure's
-describeoutput, the disabled lists andRevision.validate's result are byte-identical tomain. That holds for both revisions, at each subset level, in four configurations: the defaults, a device profile, every boolean option on, and every boolean option off.Downstream
stepfunc/dnp3's conformance configuration sets
supports.noClassAssignment = true. A release with this change rejects that key as an unknown option, so the line has to go when dnp3 upgrades.