Repository navigation
Fix a stack overflow in 3.1r1's 8.23 range read checks - #58
Merged
Merged
Conversation
The validation of a range read's response took a parameter named description, which its own description member shadowed, so describing it recursed until the stack overflowed: the x.2 test of every point type crashed the run when it reached that step. The procedure configuration test now builds every step's description, as -describe and the log do, which catches this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The x.2 test of every point type in 3.1r1's 8.23 crashed with a
StackOverflowErrorwhen it reached its range read check.The cause: the validation took a parameter named
description, which its owndescriptionmember shadowed, so describing it called itself forever. The parameter is renamed.ProcedureConfigurationTestnow also builds every step's description, as-describeand the log do, so it fails on this bug.This was found running 3.1r1 Level 3 against the dnp3 outstation.