Repository navigation
3.1r1: 9.5.3, UDP Unsolicited, and 9.5.4, unsolicited with UDP and TCP - #53
Merged
Merged
Conversation
- 9.5.3's Unsolicited Null 20000 and Unsolicited Null, Not 20000: the null unsolicited response after a restart comes over UDP to the port set up, and once confirmed, not again. - 9.5.3's Data Filled Messages tests, to port 20000, to the port the null was confirmed from, and to a fixed port other than 20000 that the device also listens on: the master's initialization (clear IIN1.7, a poll of every input, enable unsolicited) and an unsolicited response with events all come to that port. - 9.5.4: the null comes over UDP until a TCP connection is made, then over TCP only; the events too; and a read over UDP is still answered over UDP, with the TCP connection open. - The driver keeps a UDP socket bound through close(), so what the device sends while it restarts arrives; connect can keep the current connection open, for TCP and UDP at once, and make it current again later; drainDatagrams counts what arrived at a UDP socket that isn't current. The runner closes everything at the end with shutdown(). - Options: network.udp.unsolicited (with supports.unsolicitedResponse), network.udp.unsolicitedTo20000, network.udp.unsolicitedNullOtherPort with network.udp.unsolicitedPort, network.udp.unsolicitedToOriginatingPort, network.udp.fixedOtherPort, network.udpAndTcp. Every section 9 test is now implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last part of 3.1r1's section 9, after #51 and #52: every 3.1r1 network test is now implemented.
Tests
Harness
close(), so datagrams the device sends while it restarts still arrive.connectcan keep the current connection open, so the harness can use TCP and UDP at once and switch back to an earlier connection.drainDatagramscounts what has arrived at a UDP socket that isn't current. In 9.5.4, datagrams that arrive while the TCP connection is being made are logged but not counted against the device.shutdown().unsolicited.holdOffMs.Options
network.udp.unsolicited, which also needssupports.unsolicitedResponse;network.udp.unsolicitedTo20000andnetwork.udp.unsolicitedToOriginatingPort(the null tests need one or the other);network.udp.unsolicitedNullOtherPort, withnetwork.udp.unsolicitedPort;network.udp.fixedOtherPort;network.udpAndTcp.The configuration check requires the "other" ports to differ from 20000.
The 2.7
-describeoutput is unchanged.