Repository navigation
3.1r1: section 10, output control events - #50
Merged
Merged
Conversation
3.1r1's section 10 tests output events, for a device whose Device Profile claims them: output status in class 0, wherever the DUT has the events (10.3.2, 10.4.2); output status events on a change of each flag the plugin can change, with nothing else changed, and of state or value where the DUT reports those (10.3.3, 10.4.3); and output command events, for a command that succeeds and for one that doesn't (10.3.4, 10.4.4; analog in g43v2 or g43v4). Events are counted from the object headers, so command events, which carry no measurement, count too. The status event tests change back the flags they changed, also when a step fails. New options say which output events the DUT has (supports.binaryOutput .commandEvents, supports.analogOutput.commandEvents), which flags the plugin can change, whether state or value changes generate events, the analog output deadband, and whether a command resets its base. Values the tests apply stay within 16 bits; step 27's command differs by the deadband plus 10 from the value step 4 recorded. 10.4.2's step 2 names object 10 variation 2 where its desired behavior has analog output status, g40v2, which the test reads. dnp3c gains a codec for binary output command events (group 13). IntegrationPlugin gains changeOutputFlag, changeBinaryOutputState, setAnalogOutputValue and verifyCommandEventTime, with throwing defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 3.1r1's section 10, for a device whose Device Profile claims output events.
supports.binaryOutputCommandEvents,supports.analogOutputCommandEvents), which flags the plugin can change, whether state or value changes generate events, the analog output deadband, and whether a command resets its base. Values the tests apply stay within 16 bits; step 27's command differs by the deadband plus 10 from the value step 4 recorded.IntegrationPlugingainschangeOutputFlag,changeBinaryOutputState,setAnalogOutputValueandverifyCommandEventTime, with throwing defaults.