Repository navigation
Fix double free when an outstation server fails to bind - #469
Merged
Merged
Conversation
jadamcrain
force-pushed
the
fix-server-bind-double-free
branch
from
October 12, 2026 20:22
f7629b1 to
7bdaedd
Compare
outstation_server_bind took ownership of the server and freed it on any error, while the caller still held the pointer and freed it again on destroy. Borrow the server instead and mark it as failed if binding consumes it without succeeding. Closes #467.
jadamcrain
force-pushed
the
fix-server-bind-double-free
branch
from
October 12, 2026 20:36
7bdaedd to
613898b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #467.