Repository navigation
Conversation
Pressing Enter with an empty freeform answer in the native TUI dialog previously did nothing. Show an inline validation error, keep the current input, and clear the error once the user types. Esc still cancels. Fixes stepfun-ai#311
li-xiu-qi
requested review from
MelodyVAR,
Uking-xxx,
ZouR-Ma and
liuedcson
as code owners
October 27, 2026 06:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311
Problem
Native TUI
clarify_userignored an empty editor submission. Pressing Enter with an empty or whitespace-only freeform answer did nothing: no submit, no cancel, and no error. Esc still cancelled, so the broken path was specifically empty Enter.Change
Reject empty freeform answers in the native TUI dialog with an inline validation error.
Enter an answer before submittingunder the answer editor.No protocol, RPC, or persisted data change.
Validation
before：
after：
Windows, Node.js 24.21.0:
pnpm exec vitest --run test/suite/regressions/311-clarify-tui-empty-submission.test.ts: 1 test passed.pnpm run check: passed.Limitations
None.