Separate the Protocol 20 software release date from the Mainnet activation date - #2845
Conversation
…ation date The February 5, 2024 entry was headed 'Soroban Phase 1 (Mainnet Edition)'. Sibling headings use the Mainnet token for an activation date, so the heading read as the Protocol 20 Mainnet activation date. Mainnet upgraded on February 20, 2024 at 1700 UTC; February 5 is the release date of Stellar Core v20.2.0. The heading also said Phase 1 while its own table lists Phase 0 limits and fees. Rename the heading to Phase 0, drop the Mainnet token, and record the activation date in one line under the heading.
There was a problem hiding this comment.
Pull request overview
Clarifies Protocol 20’s software release and Mainnet activation dates.
Changes:
- Renames the entry from Phase 1 to Phase 0.
- Documents the February 20 Mainnet activation.
- Links the official upgrade guide.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
Substance checks out. The upgrade guide says "On February 20 at 1700 UTC, the Stellar Mainnet upgraded to Protocol 20" and its key dates list "February 20: Protocol 20 Upgrade Vote + Phase 0", and the table here does say Phase 0 limits and fees, so the old "Phase 1" heading was contradicting its own table. Nothing in the repo references the old anchor.
Two fixes in the suggestion below.
Copilot is right that "the release date of this software" is inaccurate. The table spans five components released Feb 5 through Feb 14: core v20.2.0 (Feb 5), CLI v20.3.0 (Feb 6), env v20.2.2 (Feb 13), SDK v20.3.2 and RPC v20.3.1 (both Feb 14). Feb 5 fits core only.
The date should also be Feb 20. Siblings are dated by phase settings vote rather than software release (Feb 27 Phase 1, Mar 19 Phase 2), and Feb 5 and Feb 27 carry the same core v20.2.0, so these rows are phase milestones. The page currently has no row for the Protocol 20 Mainnet activation and this is evidently it, so Feb 20 both matches the (Mainnet, DATE) convention and fills that gap.
No need to wait on #2675. That reorg isn't a settled direction, so let's land this and revisit its structure separately.
|
PR Preview: torn down |
🤖 Automated triage bot, acting for @kaankacar.
Closes #2843.
The February 5, 2024 entry was headed "Soroban Phase 1 (Mainnet Edition)". Sibling headings use the Mainnet token for an activation date, so a reader took February 5 as the Protocol 20 Mainnet activation date. The heading also said Phase 1 while its own table lists Phase 0 limits and fees. This renames the heading and records the activation date in one line.
Verification:
v20.2.0, the version in this entry's table, was published 2024-02-05T20:44:03Z. So February 5 is a software release date.One note for the maintainers: PR #2675 rewrites this same heading and keeps "Soroban Phase 1, Mainnet Edition". Whichever merges second needs a rebase.
🤖 Generated with Claude Code