Repository navigation
Conversation
For `xlm`/`native`, `"CODE:ISSUER"`, or a registered name that resolves to a SAC, register_import! now puts a mintable test asset at the address import_contract! baked in, replacing the compile error. A test Env only creates a SAC at the address derived from its asset, so the expansion registers a throwaway one and copies its contract instance to the baked address. import_contract! itself is unchanged. Rewrite the xlm_tip_jar fixture to use it, dropping its hand-written `#[cfg(test)]` twin module, and run its test from `just test-register-import`. Part of #65 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #65
Stacked on #77. Makes
register_import!work for Stellar Asset Contracts (xlm/native,"CODE:ISSUER", or a registered name that resolves to a SAC), replacing the "SAC support is coming" compile error.A test
Envonly creates a SAC at the address derived from its asset, soregister_import!registers a test asset and copies its contract instance to the addressimport_contract!baked in.import_contract!itself is unchanged. The asset is a mintable stand-in with a generated admin, even forxlm:The copy uses
Env::host().get_ledger_entry/add_ledger_entry, which are#[doc(hidden)]testutils APIs and could change across soroban-sdk majors.contract = Mockworks on SAC names;argswithoutcontractis a compile error since a SAC has no constructor. Thexlm_tip_jarfixture now importsxlmdirectly instead of through a#[cfg(test)]twin module, andjust test-register-importruns it in CI.