Repository navigation
build(deps): upgrade to stellar-cli 28.1.0 and protocol 28 - #79
Merged
Merged
Conversation
Bump soroban-cli, stellar-rpc-client, soroban-sdk, soroban-spec-tools, stellar-xdr and stellar-strkey to the 28 line, and take admin-sep 0.28.1 from crates.io. Align the CI action, justfile and CLAUDE.md pins, and pin the quickstart image the RPC tests start. Co-Authored-By: Claude <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-Authored-By: Claude <noreply@anthropic.com>
pselle
marked this pull request as ready for review
October 13, 2026 17:35
The first funding requests after the local network starts can time out, failing the first tests with Account NotFound. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
bitswell
approved these changes
Oct 13, 2026
willemneal
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the workspace from the stellar-cli 27 line to 28.1.0 (protocol 28), and brings the CI, justfile and docs pins in line with it. Supersedes dependabot #69, #71, #72 and #74.
Changes
Cargo.toml/Cargo.lock:soroban-cli27.0.0 → 28.1.0,stellar-rpc-client27.0.0 → 28.0.0,soroban-sdk27.0.0-rc.1 → 28.0.0,soroban-spec-tools27.0.0 → 28.1.0,stellar-xdr=27.0.0 → =28.0.0,stellar-strkey0.0.16 → 0.0.18.admin-sepnow comes from crates.io (0.28.1, the SDK 28 release) instead of a git rev..github/workflows/rust.yml,tests.yml:stellar/stellar-cliaction v28.0.0 → v28.1.0..github/workflows/tests.yml: new "Warm up friendbot" step that funds a throwaway account before the RPC tests run.justfile,CLAUDE.md:just setupinstalls stellar-cli 28.1.0 (was 26.0.0).Notes for review
stellar-climajor inCargo.toml, so the local network now starts at protocol 28 on the floatingtestingquickstart image.keys generate --fundtimed out in the first four tests, which then failed withAccount NotFound. The same commit passed on re-run.cargo fmt --checkandjust clippy-testare clean.