Repository navigation
feat(catalog): let a partner send a section subtitle and title icon (STORE-5421) - #80
Open
kirill-stash wants to merge 1 commit into
Open
kirill-stash wants to merge 1 commit into
kirill-stash wants to merge 1 commit into
Conversation
kirill-stash
marked this pull request as ready for review
October 29, 2026 16:57
kirill-stash
force-pushed
the
store-5421
branch
from
October 30, 2026 10:16
98527a4 to
d454bdd
Compare
![stash-ripley[bot]](https://avatars.githubusercontent.com/in/4427141?s=60&v=4){kind=small}
kirill-stash
force-pushed
the
store-5421
branch
from
October 30, 2026 10:20
d454bdd to
311e3be
Compare
dinosoeren
approved these changes
Oct 30, 2026
| repeated Group groups = 4 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional offer groups within this section; array order is display order"}]; | ||
| optional Background background = 5 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional background styling for this section"}]; | ||
| optional google.protobuf.Timestamp display_expiration = 6 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Optional timestamp for display-only section UI such as a countdown (e.g., 'Offers expire in 7d 19h'). Does not change purchase rules; only each offer's own expiration is enforced at purchase time."}]; | ||
| optional LocalizableText subtitle = 8 [(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {description: "Not shown yet: web shops ignore this field until support ships. Optional short line shown under the section header, resolved to the player's language like any other text field. A subtitle that is absent or resolves to blank is not shown."}]; |
Collaborator
There was a problem hiding this comment.
once the submodule bump publishes this, partners read "web shops ignore this field", and nothing in this stack removes the sentence after the render ships. could we drop "Not shown yet: web shops ignore this field until support ships." here and on line 1296, then regenerate? public-api field docs read as built.
Author
There was a problem hiding this comment.
Done: the sentence is gone from both fields here, and from empty_state in #81, and the docs are regenerated. Field docs now read as built. The Stash side stays quiet with partners until the shop renders the fields.
— Beast
…STORE-5421) A partner can show a short line under a webshop section title, such as a savings line, and an icon beside the title. A catalog section had no field for either. Section gains an optional LocalizableText subtitle (8), typed like the shop banner subtitle, and an optional icon_image_url (9) with the same URI rule as SectionHeader.icon_image_url. Both are additive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kirill-stash
force-pushed
the
store-5421
branch
from
October 30, 2026 17:05
311e3be to
c79f4be
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/stashgg/issue/STORE-5421/partner-catalog-section-gains-optional-subtitle-and-title-icon-public
Intent
Partners need a place in the catalog contract to send a short subtitle and a title icon for each catalog section, so a partner can show a line such as "Save up to 20% on gems." and an icon beside a section title on its webshop. Both fields are optional, and a partner that sends neither keeps the contract it has today.
Verification
urirule matchesSectionHeader.icon_image_url; no Stash build reads the field yet.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Note
💥 Blast Radius — Low Risk
Intent: Partners can supply a subtitle and title icon for catalog sections.
The shared catalog contract adds optional fields; responses that omit them retain their existing shape.
Overview
Section.subtitleandSection.icon_image_urladd display metadata toGetCatalogResponse.Shop reach: none beyond adopters — shops whose backends omit both fields keep their existing response shape. Adoption by shop is not enumerated in this checkout.
Data/proto: A partner backend can send
catalog.sections[].subtitleandiconImageUrlto the catalog reader for section rendering. Existing responses omit both; readers must adopt the fields before displaying them.Scope is the shared catalog schema and two generated documentation files; existing field definitions are unchanged.
Not reviewed: 2 generated file(s) — marked
linguist-generatedin.gitattributes:docs/gen/redoc.v1.html,docs/gen/swagger.v1.json.