Repository navigation
feat(loyalty): the loyalty config API carries an optional spend conversion table (ENG-13206) - #77
Open
richardelms-stash wants to merge 1 commit into
Open
richardelms-stash wants to merge 1 commit into
richardelms-stash wants to merge 1 commit into
Conversation
richardelms-stash
marked this pull request as ready for review
October 28, 2026 15:19
dinosoeren
reviewed
Oct 28, 2026
richardelms-stash
force-pushed
the
eng-13206
branch
from
October 28, 2026 20:47
1914922 to
9449378
Compare
dinosoeren
approved these changes
Oct 29, 2026
richardelms-stash
force-pushed
the
eng-13206
branch
from
October 29, 2026 13:45
9449378 to
bf0f30c
Compare
…rsion table (ENG-13206) UpdateLoyaltyConfigRequest accepts spendConversion, one price row in every currency the partner sells in, from which earning converts a non-USD purchase to its US dollar equivalent. GetLoyaltyConfig and UpdateLoyaltyConfig report the stored row, the rate derived per currency and when it last changed. Omitting it leaves the stored table; an empty tiers list removes it. Additive: new fields 7, 5 and 6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
richardelms-stash
force-pushed
the
eng-13206
branch
from
October 29, 2026 14:43
bf0f30c to
11ff1c3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/stashgg/issue/ENG-13206/the-public-api-messages-for-spendconversion-and-its-derived-rates
Intent
A partner's tool needs a published wire shape for sending its price row with its loyalty configuration and for reading back what Stash stored: the row itself, the rate derived for each currency, and when the table last changed. Leaving the row out of an update keeps what is stored, and sending an empty one removes it.
Need help on this PR? Tag
@codesmith-botwith what you need.Note
💥 Blast Radius — Low Risk
Intent: Let a partner's tool submit a loyalty price row and read back the stored row, derived rates and last-change time.
The shared contract is additive: omitting
spend_conversionleaves the stored table unchanged.Overview
UpdateLoyaltyConfigaccepts an optional row; configuration responses expose that row,rates_per_usdandupdated_at.Shop reach: Shops with a stored conversion table, count unknown; their configuration responses can include the new field. Writes target the shop named by
shop_id.Data/proto: A tool sends
spend_conversion.tiers[].prices→ the shop's stored row →rates_per_usdandupdated_atin configuration responses. With a table stored, purchases in currencies missing from the row earn no points.Scope is
server/ingress/loyalty/v1/service.protoand two excluded generated files; existing fields remain unchanged.Not reviewed: 2 generated file(s) — marked
linguist-generatedin.gitattributes:docs/gen/redoc.ingress.v1.html,docs/gen/swagger.ingress.v1.json.