Repository navigation
Spawn login sub-shells - #328
mclasmeier wants to merge 2 commits into
Conversation
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 27 seconds. View limit details
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update shell invocation cmd/subshell.go |
The interactive subshell command now passes both -l and -i to the resolved shell. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Merge Risk: 
1a769
-
The PR adds login mode to interactive subshells without any established merge-blocking defect.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: interactive subshells now start as login shells. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
It was reported that environmental setup (aliases) were missing in roxies subshell.
Using login shells should fix this.
--
Also, required for e2e test, work around google-github-actions/auth#535 — recent gcloud SDK versions crash when
gke-gcloud-auth-pluginreads the credential file set byCLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE.After
setup-gcloudstores credentials in gcloud's internal store, unset the override so the auth plugin uses the stored credentials instead.This mirrors the fix applied in stackrox/stackrox@f82064bc1e.