Conversation
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
PR #344 made Fastly store selection depend on a shared
edgezero_runtime_envConfig Store and service/version-scoped descriptor keys. That added mutable shared state, put Fastly service IDs into configuration names, and made application runtime code participate in deployment-target selection.This change removes that descriptor architecture. Applications keep stable logical store IDs in
edgezero.toml. The selected deployment environment chooses physical Config, KV, and optional Secret Stores through canonicalEDGEZERO__STORES__...__NAMEvariables. Before publication, managed Fastly deployment binds those physical resources to the logical aliases on the unpublished service version.Production and staging can select the same or different physical stores while deploying the same immutable application release. A logical Config Store always uses its logical ID as the entry key. For example, production and staging can select
config-prodandconfig-stage, while both versions expose the alias and keyapp_config.Changes
edgezero_runtime_env, runtime descriptors, service/version selector keys, staging selector stores,EDGEZERO_FASTLY_BUILD_SETTINGS, and all compatibility behavior for the Support optional typed secret paths and Fastly store mappings #344 contract.__NAMEvariables and reject present blank or invalid selectors before provider I/O.config,kv-store, andsecret-store.service resource-link ...andservice version ...hierarchy, removing per-call deprecation warnings while retaining the reviewed 15.1.0 pin.pubsub,logentries, ands3; they never request the invalidgooglepubsubpath. Verify the source, fresh clone, post-mutation draft, and final readback without calling the Compute-incompatible diff endpoint.edgezero.toml, and package bytes identical across publishers and targets. A release includes and digests only the selected adapter manifest at its declared relative path.config push/diff --adapter <name>validation to the selected adapter while retaining whole-projectconfig validate.package-application-release-fastlyand supplies only Fastly policy.deploy-core/scripts/run-app-cli.shin place. It owns exact argv execution, confinement, environment scrubbing, mutation signalling, and exit propagation; thin Fastly wrappers own Fastly arguments, credentials, and output policy.deploy-fastly/tests.build-app-clitoapp-cli.tarwhile preserving the configurable artifact name, application binary/package names, and immutable membercli/app-cli.tar.setup-rust-build-cacheaction for release producers. Its requiredapp-namescopes Cargo dependency sources and optional Cargo target artifacts to one application, whilesccachereuses compiler outputs across later native and WASM builds. Existing build commands remain unchanged.lifecycle_protocol: 1, and bind every lifecycle action to the selected source revision.Fastly does not expose a publication compare-and-swap token. Deployments and other version mutators for one service must share caller-side serialization. The source/clone and final snapshot checks reject observed interference; serialization closes the remaining provider time-of-check/time-of-use window.
Downstream consumers of the build action must consume
app-cli.tar.Closes #380
Validation
cargo test --locked --workspace --all-targetsworkspace tests,cli tests,axum tests, andapp-demo testsCI checks; isolated adapter CLI suites pass Axum 38, Cloudflare 53, Fastly 304, and Spin 126 tests, with 111 Axum runtime testscargo clippy --workspace --all-targets --all-features -- -D warningscargo check --workspace --all-targets --features "fastly cloudflare spin"cargo fmt --all -- --checkandgit diff --check.github/actions/deploy-core/tests/run.sh— 589 passed, 0 failed, 5 expected platform skips.github/actions/setup-rust-build-cache/tests/run.shfixture-releasefell from 1m50s to 32s andstore-free-releasefrom 2m5s to 33s; their real Cargo release builds completed in 7.09s and 7.77s, and every downstream deployment smoke passed.github/actions/release-core/tests/run.sh.github/actions/package-application-release-fastly/tests/run.sh— Linux test is exercised by CI; non-Linux runners skip itrg 'edgezero-cli\\.tar'returns no product-contract references