Repository navigation
Conversation
Signed-off-by: stacknil <219124580+stacknil@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add six missing entries to the report event counter: three sudo/su audit types, accepted and failed SSH keyboard-interactive, and SSH maximum-authentication-attempts. The counter now covers all 15 EventType entries, including the Unknown sentinel.
Why
Successfully parsed events could increase
parsed_event_countwhile disappearing fromevent_counts. Refs #128.Behavior change
Global and per-host JSON counts and global Markdown counts include those existing event types. Focused regressions exercise both input modes and a minimal two-host fixture.
Validation
Both regression stages failed before their corresponding additions and passed afterward. The Linux/GCC 13.3 warnings-as-errors build and complete CTest passed 7/7;
git diff --checkpassed. A supplemental local CLI check verified count conservation for all 14 normalized types globally and per host. Windows/MSVC was not run locally; the Windows GitHub Actions job passed all seven CTest entries.Compatibility
Detector eligibility and findings, parser/warning behavior, report schema/version, CSV, timestamps, and existing report goldens are unchanged. Consumers will see previously missing event-count rows and corrected totals. The production diff is six counter entries; no goldens were regenerated. Rollback is a revert of this commit.