fix(sfs): name the update operation in the update diagnostics - #1766
Merged
rubenhoenle merged 1 commit intoSep 15, 2026
Merged
Conversation
devpie
force-pushed
the
fix/sfs-update-error-summary
branch
from
September 14, 2026 12:22
b21d129 to
b2da744
Compare
8 tasks
marceljk
approved these changes
Sep 15, 2026
rubenhoenle
approved these changes
Sep 15, 2026
rubenhoenle
enabled auto-merge (squash)
September 15, 2026 11:54
Three diagnostics inside Update paths were copied from Create and still reported a creation failure. stackitcloud#1740 fixed the resource pool update wait; this covers the ID guard next to it and both update diagnostics of the share resource. Only the summaries change, the details are accurate as they are.
rubenhoenle
force-pushed
the
fix/sfs-update-error-summary
branch
from
September 15, 2026 11:54
b2da744 to
7cde5cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three diagnostics inside
Updatepaths were copied fromCreateand still report a creation failure. #1740 corrected the resource pool's update wait; this covers what is left of the same copy-paste in the SFS service:sfs/resourcepool: the missing-ID guard right above the line feat(sfs): make resource pool wait timeouts configurable #1740 correctedsfs/share: the same guard, and the diagnostic of the update waitOnly the summaries change. The details are left alone on purpose:
UpdateShareWaitHandlerpollsGetShareuntil the share reachescreated, and a share has noupdatingstate (sfs@v0.11.2documentspending,creating,created,error,deleting), so after aPATCHthe first poll normally returns right away.share getdescribes that better than a wait would.Text only, no behaviour change. There is no issue for this; the wording was noticed while working on #1740.
Checklist
make fmtexamples/directory) — not applicable, no schema changemake generate-docs(will be checked by CI)ExpectErrorpatterns cover the create pathsmake test(will be checked by CI)make lint(will be checked by CI)