Skip to content

fix(sfs): name the update operation in the update diagnostics - #1766

Merged
rubenhoenle merged 1 commit into
stackitcloud:mainfrom
devpie:fix/sfs-update-error-summary
Sep 15, 2026
Merged

rubenhoenle merged 1 commit into
stackitcloud:mainfrom
devpie:fix/sfs-update-error-summary

Conversation

@devpie

@devpie devpie commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Description

Three diagnostics inside Update paths were copied from Create and still report a creation failure. #1740 corrected the resource pool's update wait; this covers what is left of the same copy-paste in the SFS service:

Only the summaries change. The details are left alone on purpose: UpdateShareWaitHandler polls GetShare until the share reaches created, and a share has no updating state (sfs@v0.11.2 documents pending, creating, created, error, deleting), so after a PATCH the first poll normally returns right away. share get describes that better than a wait would.

Text only, no behaviour change. There is no issue for this; the wording was noticed while working on #1740.

Checklist

  • Issue was linked above — no issue exists; happy to open one if you prefer
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory) — not applicable, no schema change
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated — not applicable: no test asserts these strings, and the existing ExpectError patterns cover the create paths
  • Acceptance tests got implemented or updated — not applicable for a diagnostic string
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@devpie
devpie requested a review from a team as a code owner September 14, 2026 12:01
@devpie
devpie force-pushed the fix/sfs-update-error-summary branch from b21d129 to b2da744 Compare September 14, 2026 12:22
@rubenhoenle
rubenhoenle enabled auto-merge (squash) September 15, 2026 11:54
Three diagnostics inside Update paths were copied from Create and still
reported a creation failure. stackitcloud#1740 fixed the resource pool update wait; this
covers the ID guard next to it and both update diagnostics of the share
resource. Only the summaries change, the details are accurate as they are.
@rubenhoenle
rubenhoenle force-pushed the fix/sfs-update-error-summary branch from b2da744 to 7cde5cf Compare September 15, 2026 11:54
@rubenhoenle
rubenhoenle merged commit 4614df6 into stackitcloud:main Sep 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants