Skip to content

feat(sca): onboard sca service - #11373

Open
JYisus wants to merge 17 commits into
stackitcloud:mainfrom
JYisus:oas-bot-34598867041/sca
Open

JYisus wants to merge 17 commits into
stackitcloud:mainfrom
JYisus:oas-bot-34598867041/sca

Conversation

@JYisus

@JYisus JYisus commented Sep 14, 2026

Copy link
Copy Markdown

Description

  • Auto-generated SCA code.
  • Include required meta files (RELEASE.md, VERSION, CHANGELOG.md)
  • Implement waiters.
  • Create examples

JIRA issue: https://jira.schwarz/browse/SCA-231

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@JYisus
JYisus requested a review from a team as a code owner September 14, 2026 11:54
Comment thread go.work
Comment thread examples/sca/sca.go Outdated
@rubenhoenle

Copy link
Copy Markdown
Member

Just some quick feedback after a first glance, a detailed review will follow from the collegues responsible for your domain :)

@JYisus
JYisus requested a review from rubenhoenle September 14, 2026 12:36
Comment thread examples/sca/sca.go
Comment thread services/sca/LICENSE.md Outdated
Comment thread services/sca/v1alphaapi/wait/wait_test.go
Comment thread services/sca/v1alphaapi/wait/wait_test.go Outdated
Comment thread services/sca/v1alphaapi/wait/wait_test.go Outdated
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go Outdated
Comment thread services/sca/v1alphaapi/wait/wait.go
Comment thread services/sca/v1alphaapi/wait/wait.go
Comment thread services/sca/v1alphaapi/wait/wait.go
Comment thread examples/sca/sca.go
Comment thread examples/sca/sca.go Outdated
Comment thread services/sca/v1alphaapi/wait/wait_test.go
Comment thread examples/sca/sca.go
Comment on lines +123 to +125
if err != nil {
fmt.Fprintf(os.Stderr, "Error when calling `GetApplicationLogs`: %v\n", err)
}

@SerseusWasTaken SerseusWasTaken Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.Exit(1) is missing here.
also when running the example i run into this error here:
Error when calling GetApplicationLogs: instance is required and must be specified
Did the updated example run for you or could this be related to my environment?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I tested the examples with an outdated version of the API.
I also commented the error state in the createOrUpdateApplication waiter because of an internal behaviour of our operator and Kubernetes. We are working on a workaround to solve it, but we would like to merge this and open a new PR with this fix to unlock other tasks that depends on merging and releasing the first version of the sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants