Conversation
|
Just some quick feedback after a first glance, a detailed review will follow from the collegues responsible for your domain :) |
| if err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error when calling `GetApplicationLogs`: %v\n", err) | ||
| } |
There was a problem hiding this comment.
os.Exit(1) is missing here.
also when running the example i run into this error here:
Error when calling GetApplicationLogs: instance is required and must be specified
Did the updated example run for you or could this be related to my environment?
There was a problem hiding this comment.
Fixed. I tested the examples with an outdated version of the API.
I also commented the error state in the createOrUpdateApplication waiter because of an internal behaviour of our operator and Kubernetes. We are working on a workaround to solve it, but we would like to merge this and open a new PR with this fix to unlock other tasks that depends on merging and releasing the first version of the sdk.
Description
JIRA issue: https://jira.schwarz/browse/SCA-231
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)