fix(examples): stop tracking generated build output - #24
Merged
h3adex merged 1 commit intoSep 16, 2026
Merged
Conversation
060-policies-config.tf writes build/config.json through a local_file resource on every terraform apply, so the checked-in copy was a build artifact. It carried the project ID and service account email of the environment it was generated in, and any apply left it as a spurious diff. Ignore build/ repository-wide so no example or module can commit generated output again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
examples/opa-policy-reactive-agent/build/config.jsonis a build artifact, not source.060-policies-config.tfwrites it through alocal_fileresource on everyterraform apply, so the checked-in copy was generated output that got committed by mistake in 71d9bfc.Two consequences:
terraform applyrewrote the file and left it as a spurious diff in the contributor's working tree.This PR removes the file and adds
build/to.gitignore. The pattern has no leading slash, so it covers anybuild/directory anywhere in the repo, not just this one.Notes for reviewers
cloud-init/policy-engine.yaml.tftplthroughtemplatefile()(see050-policy-engine-host.tf), andscripts/policy_runner.pyreads/etc/stackit-policy-engine/config.jsonthere. Removing the local artifact does not change the example; the next apply regenerates it.100755, an executable JSON file.check_readme_tags.py,check_todos.py,generate_agents_md.py --checkand the pre-commit hygiene hooks all pass. The ignore pattern was tested againstbuild/directories at two different depths, including one outsideexamples/.Checklist
🤖 Generated with Claude Code