Skip to content

Warn that diagnostic access includes backups with saved credentials #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frahlg merged 1 commit into from
Oct 18, 2026
Merged

Warn that diagnostic access includes backups with saved credentials #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/diagnostic-access-consent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ftw": patch
---

The Access page states that technical diagnostics include source, logs and full backups, which can contain saved credentials, before the owner grants access.
2 changes: 1 addition & 1 deletion web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@ <h3>Price bars (top of the chart)</h3>
<script src="/settings/tabs/planner.js?v=cvxpy1"></script>
<script src="/settings/tabs/ha.js?v=modbusproxy2"></script>
<script src="/settings/tabs/app.js?v=terms2"></script>
<script src="/settings/tabs/access.js?v=access2"></script>
<script src="/settings/tabs/access.js?v=access3"></script>
<script src="/settings/tabs/fleet.js?v=terms2"></script>
<script src="/settings/tabs/notifications.js?v=tabsplit2"></script>
<script src="/settings/tabs/ev.js?v=tabsplit2"></script>
Expand Down
2 changes: 1 addition & 1 deletion web/settings/tabs/access.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"ftw.events.read": "See alerts and events",
"ftw.logs.read": "Read the box's logs, with names and secrets taken out",
"ftw.config.read": "Read the settings, with names and secrets taken out",
"ftw.diag.run": "Run checks that change nothing",
"ftw.diag.run": "Read full technical diagnostics, source, logs and backups; backups can contain saved credentials",

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Complete the required human browser inspection

The commit states that human review of the rendered consent remains pending. Because this changes security-sensitive consent text shown in the Access UI, mock rendering and automated tests do not satisfy the repository's requirement that a human inspect the rendered interface; complete that inspection before treating the change as review-ready.

AGENTS.md reference: AGENTS.md:L142-L144

Useful? React with 👍 / 👎.

"ftw.dispatch.hold": "Act at once, for a few minutes at a time, within these limits",
"ftw.goals.request": "Ask for lasting changes, each waiting for your yes here",
};
Expand Down
7 changes: 7 additions & 0 deletions web/settings/tabs/access.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ describe("the page's words follow the registry", () => {
for (const scope of Object.keys(P.SCOPE_WORDS)) assert.ok(agentScopes.includes(scope), scope);
});

it("warns that diagnostic access reads full backups that can contain saved credentials", () => {
const words = P.SCOPE_WORDS["ftw.diag.run"];
assert.match(words, /full technical diagnostics, source, logs and backups/);
assert.match(words, /backups can contain saved credentials/);
assert.doesNotMatch(words, /checks that change nothing/);
});

it("has words for every op an assistant may name", () => {
assert.ok(agentOps.length >= 5);
for (const op of agentOps) assert.ok(P.OP_WORDS[op], op);
Expand Down
Loading