Repository navigation
fix(web): keep the statistics prompt across the Overview row - #1711
Merged
Merged
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
On
v0.149.1-beta.1, the statistics and Cloud terms prompt takes one of Overview’s twelve columns. Its text wraps into a tall strip and pushes the dashboard below the screen. Make the prompt span the full row when its module creates it.Scope and safety
Keep the fix in
project-statistics.js; open PR #1694 has right of way onapp.css. Add a patch changeset and let the existing test DOM hold element styles.Verification
npm test: 767 passed.make verify: passed. The first run hit a UDP port collision inTestBulkTunTakesTheBulkStream; the full retry passed.Checklist
The rendered desktop and phone views are in the chat. Fredrik asked for the fix and merge; human UI review can follow on beta under the repository’s review policy.