Repository navigation
Limit household statistics to 48 hours under new terms - #1710
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 703e3f47c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project statistics currently keep household hours for 13 months although the public view uses one day. Limit them to 48 hours under
ftw-project-stats-2026-10-v3andftw-cloud-2026-10-v3. Core's owner information, UI and protocol now state that limit; older choices require a fresh answer. The service still needs the exact approved policy, so this does not start collection.The protocol exports the retention age for Cloud and updates only the changed signed statistics/QUIC vectors. Paired changes in srcfl/ftw-cloud, srcfl/ftw-app and srcfl/ftw-web enforce the limit and use the same terms.
Validation:
make verifypasses. Fredrik inspected the rendered local and Cloud views and approved the 48-hour text on 17 October 2026. This UI approval does not sign the DPIA or enable collection.Owner decision: Fredrik explicitly approved the minor release class for policy v3 and the fresh terms answer on 17 October 2026. This approval covers the release class; it does not enable hourly collection or sign the DPIA.
Review follow-up: corrected the release class to minor and all remaining protocol policy references to v3.
Paired Cloud: srcfl/ftw-cloud#33; iOS: srcfl/ftw-app#88.
Paired public privacy notice: srcfl/ftw-web#24.
Release scope: Fredrik asked to complete the work without publishing a new beta. Releases remain a separate step in Claude.