Repository navigation
fix(cloud): stop sharing when follow-up off writes fail - #1704
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an owner turns Cloud off and Core saves the durable off flag but a later config write fails, the active grant could keep serving live data and statistics until restart. Stop the in-memory link and grant immediately after the durable flag succeeds, then save the follow-up records. The existing load path already honours that flag after restart.
Regression tests reproduce all three failed follow-up writes: the local statistics-answer record, link record and grant record. All three fail before this fix. Verify that readable data, phone tunnels, session metadata and daily reports stop while the failed storage write still returns an error. This follows #1700; it changes no UI, policy scope or collection flag.
Validation: cloudlink/API race suites and full
GOFLAGS=-p=2 make verifypass. The first v0.149.0 beta build was cancelled before publication so this failure path does not reach the home-box trial. A patch changeset is included. Paired Cloud terms remain srcfl/ftw-cloud#32 and iOS srcfl/ftw-app#87.After merging the current master, full make verify, the complete race script and all CI gates pass. The first CI race job timed out in an unchanged OCPP socket test; its retry and the updated branch pass. Ten isolated repetitions passed. An additional 100-repetition run hit one local listener-startup timeout in that existing fixture. No OCPP implementation or test was changed by this PR.