Repository navigation
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core v0.147.0 stopped opening the Frankfurt relay socket in #1687, but the relay client, retry/rotation code, HTTP deadman client and Watch exchange still remained in the source. Software identity also still resolved the retired relay host when asking the kernel which physical interface to use.
This removes those retired paths and uses
cloud.ftw.energyfor that route lookup. App sessions keep the existing Cloud tunnel and Noise handshake. The startup log now says the app link is ready through Cloud, rather than claiming an established relay connection. Stored identity files and keys are unchanged by this patch; route ambiguity and interface checks still fail closed.Relay and exchange fixtures are removed. The command retry and in-flight API revocation tests now run through the Cloud tunnel; the existing tunnel tests still cover pairing, forged device IDs, replay, revocation and live updates. The identity regression fails before the host change and passes afterward, including shuffled IPv4/IPv6 answers and physical-interface checks.
Validation: full
make verifyand race tests forappproto,appuplinkandgatewayidentity. No box update, restart or release was performed. Target-box preservation and startup checks belong to the next beta trial.The older overlapping #1633 is explicitly paused in favor of the existing Cloud tunnel. This follows the owner's instruction to remove the remaining relay code and adds no replacement relay or fallback.