Skip to content

Fix public Cloud collection in the Workers runtime - #97

Merged
frahlg merged 1 commit into
mainfrom
fix/stats-workers-redirect
Oct 17, 2026
Merged

frahlg merged 1 commit into
mainfrom
fix/stats-workers-redirect

Conversation

@frahlg

@frahlg frahlg commented Oct 17, 2026

Copy link
Copy Markdown
Member

The real 15:23 UTC scheduled event still failed both public Cloud collectors after #96. A remote Cloudflare preview reproduced the exact error: Workers rejects redirect: error before sending a request. Node had accepted that mode, and the previous fetch stubs hid the difference.

Use manual in both collectors. Their existing non-OK check rejects every 3xx response without following its destination. No new endpoint, privilege, or collection scope.

The two regressions construct a real Workers Request before returning a redirect; both fail on the old code and pass on this change, with one fetch and no stored feed. Full verification passes: 1133 app tests (2 skipped), 27 Worker tests, types and production builds. The remote preview now receives the expected disabled 503 and public fleet 200 from Cloud. Verify the deployed scheduled event as well; hourly household collection stays off pending the privacy review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-17T15:28:12.771188Z 5fb36dc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
ftw-webapp 5fb36dc Commit Preview URL

Branch Preview URL
Oct 17 2026, 03:28 PM

@frahlg
frahlg merged commit c7e6053 into main Oct 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant