Repository navigation
feat: retire relay fleet reports and browser offline notices #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // Package fleet reduces anonymous box reports to bounded daily counts. | ||
| package fleet | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "io" | ||
| "net/http" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/srcfl/ftw-cloud/internal/registry" | ||
| "github.com/srcfl/ftw/go/protocol/fleetwire" | ||
| ) | ||
|
|
||
| type Service struct { | ||
| reg *registry.Registry | ||
| now func() time.Time | ||
| mu sync.Mutex | ||
| at time.Time | ||
| tokens float64 | ||
| } | ||
|
|
||
| func New(reg *registry.Registry) (*Service, error) { | ||
| if err := reg.FleetInit(); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := reg.FleetPrune(time.Now()); err != nil { | ||
| return nil, err | ||
| } | ||
| return &Service{reg: reg, now: time.Now, tokens: 120}, nil | ||
| } | ||
|
|
||
| // ServeHTTP accepts reports only. Public requests never read totals. | ||
| func (s *Service) ServeHTTP(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Cache-Control", "no-store") | ||
| if r.Method != http.MethodPost { | ||
| w.Header().Set("Allow", http.MethodPost) | ||
| w.WriteHeader(http.StatusMethodNotAllowed) | ||
| return | ||
| } | ||
| if !s.allow() { | ||
| w.WriteHeader(http.StatusTooManyRequests) | ||
| return | ||
| } | ||
| data, err := io.ReadAll(http.MaxBytesReader(w, r.Body, fleetwire.MaxBodyBytes)) | ||
| if err != nil { | ||
| w.WriteHeader(http.StatusRequestEntityTooLarge) | ||
| return | ||
| } | ||
| report, err := fleetwire.Decode(data) | ||
| if err != nil { | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| return | ||
| } | ||
| ok, err := s.reg.FleetPut(report, s.now()) | ||
| switch { | ||
| case err != nil: | ||
| w.WriteHeader(http.StatusServiceUnavailable) | ||
| case !ok: | ||
| w.WriteHeader(http.StatusTooManyRequests) | ||
| default: | ||
| w.WriteHeader(http.StatusNoContent) | ||
| } | ||
| } | ||
|
|
||
| // Stats belongs only on the operator's loopback listener. | ||
| func (s *Service) Stats(w http.ResponseWriter, r *http.Request) { | ||
| w.Header().Set("Cache-Control", "no-store") | ||
| if r.Method != http.MethodGet { | ||
| w.WriteHeader(http.StatusMethodNotAllowed) | ||
| return | ||
| } | ||
| view, err := s.reg.FleetView(s.now()) | ||
| if err != nil { | ||
| w.WriteHeader(http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
| w.Header().Set("Content-Type", "application/json") | ||
| _ = json.NewEncoder(w).Encode(view) | ||
| } | ||
|
|
||
| // One shared budget stores no addresses and admits five reports a second. | ||
| func (s *Service) allow() bool { | ||
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
| now := s.now() | ||
| if !s.at.IsZero() { | ||
| s.tokens = min(120, s.tokens+max(0, now.Sub(s.at).Seconds())*5) | ||
| } | ||
| s.at = now | ||
| if s.tokens < 1 { | ||
| return false | ||
| } | ||
| s.tokens-- | ||
| return true | ||
| } | ||
|
|
||
| func (s *Service) Prune(now time.Time) error { return s.reg.FleetPrune(now) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| package fleet | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "github.com/srcfl/ftw-cloud/internal/registry" | ||
| "github.com/srcfl/ftw/go/protocol/fleetwire" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "path/filepath" | ||
| "sync" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestReportsBecomeOnlyBoundedDailyTotalsAcrossARestart(t *testing.T) { | ||
| path := filepath.Join(t.TempDir(), "registry.db") | ||
| reg, err := registry.Open(path) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| svc, err := New(reg) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| now := time.Now().UTC().Truncate(24 * time.Hour) | ||
| svc.now = func() time.Time { return now } | ||
| report := fleetwire.Report{Schema: fleetwire.Schema, Version: "v0.146.0", Channel: "stable", Drivers: []string{}, Battery: "none", Zone: "SE4", Age: "unknown"} | ||
| raw, _ := json.Marshal(report) | ||
| var wg sync.WaitGroup | ||
| for range 100 { | ||
| wg.Go(func() { | ||
| w := httptest.NewRecorder() | ||
| r := httptest.NewRequest("POST", "/v1/fleet", bytes.NewReader(raw)) | ||
| r.RemoteAddr = "198.51.100.8:443" | ||
| svc.ServeHTTP(w, r) | ||
| if w.Code != 204 { | ||
| t.Errorf("status %d", w.Code) | ||
| } | ||
| }) | ||
| } | ||
| wg.Wait() | ||
| if err := reg.Close(); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| reg, err = registry.Open(path) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer reg.Close() | ||
| svc, err = New(reg) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| view, err := reg.FleetView(now) | ||
| if err != nil || len(view.Days) != 1 || view.Days[0].Reports != 100 { | ||
| t.Fatal(view, err) | ||
| } | ||
| for i := 1; i < 92; i++ { | ||
| if ok, err := reg.FleetPut(report, now.AddDate(0, 0, i)); err != nil || !ok { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
| view, _ = reg.FleetView(now.AddDate(0, 0, 91)) | ||
| if len(view.Days) != 90 { | ||
| t.Fatal(len(view.Days)) | ||
| } | ||
| // A long gap expires old populated dates, even without another report. | ||
| if err := reg.FleetPrune(now.AddDate(1, 0, 0)); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| view, _ = reg.FleetView(now.AddDate(1, 0, 0)) | ||
| if len(view.Days) != 0 { | ||
| t.Fatal("old totals survived", view) | ||
| } | ||
| for _, tc := range []struct { | ||
| method, body string | ||
| code int | ||
| }{{"GET", "", 405}, {"POST", `{"home":"x"}`, 400}, {"POST", string(make([]byte, 4097)), 413}} { | ||
| w := httptest.NewRecorder() | ||
| svc.ServeHTTP(w, httptest.NewRequest(tc.method, "/v1/fleet", bytes.NewBufferString(tc.body))) | ||
| if w.Code != tc.code { | ||
| t.Fatal(w.Code, tc) | ||
| } | ||
| } | ||
| w := httptest.NewRecorder() | ||
| svc.Stats(w, httptest.NewRequest(http.MethodGet, "/fleet/stats", nil)) | ||
| if w.Code != 200 || bytes.Contains(w.Body.Bytes(), []byte("198.51.100")) { | ||
| t.Fatal(w.Code, w.Body.String()) | ||
| } | ||
| // The only extra table holds date and aggregate JSON, not source addresses. | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.