Repository navigation
Make MCP setup a separate owner choice in Access - #92
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afe48c7b52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give setup its own choice when an owner approves or renews an assistant. It starts off, even if temporary control is on. The grant includes setup only after an explicit choice, and the page explains full settings access, confirmation before saving and separate restart confirmation. Keep diagnostics wording accurate about source, logs and backups that can hold saved credentials.
The shared registry and Swift role table match the paired Core setup contract. Older offers without setup still cannot grant it.
Paired Core: srcfl/ftw#1732 (on foundation #1731), Cloud: srcfl/ftw-cloud#37, webapp: srcfl/ftw-webapp#99. All use codex/mcp-setup-contract.
Validation: all 548 Swift tests in 82 suites, the full iOS Simulator build and shared JVM tests passed. The actual offer view was inspected in a separate iOS 27 simulator: setup starts off, can be selected while temporary control stays off, and its copy changes accordingly. No real grant was submitted. No TestFlight or store upload in this PR.